Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: services/shape_detection/public/interfaces/barcodedetection.mojom

Issue 2875243002: RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)
Patch Set: RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shape_detection/public/interfaces/barcodedetection.mojom
diff --git a/services/shape_detection/public/interfaces/barcodedetection.mojom b/services/shape_detection/public/interfaces/barcodedetection.mojom
index 27f95ecdaa72cb46d2d95717fe6556e9fb76db2b..5ae9aef56d7a9992c36bc7e06c9626e5f9785ec2 100644
--- a/services/shape_detection/public/interfaces/barcodedetection.mojom
+++ b/services/shape_detection/public/interfaces/barcodedetection.mojom
@@ -6,6 +6,7 @@
module shape_detection.mojom;
+import "skia/public/interfaces/bitmap.mojom";
import "ui/gfx/geometry/mojo/geometry.mojom";
struct BarcodeDetectionResult {
@@ -17,9 +18,7 @@ struct BarcodeDetectionResult {
};
interface BarcodeDetection {
- // |frame_data| contains tightly packed image pixels in ARGB32 format,
- // row-major order.
- // TODO(mcasas): Consider using mojo::Bitmap here, https://crbug.com/665488.
- Detect(handle<shared_buffer> frame_data, uint32 width, uint32 height)
+ // |bitmap_data| contains tightly packed image pixels in row-major order.
+ Detect(skia.mojom.Bitmap bitmap_data)
=> (array<BarcodeDetectionResult> results);
};
« no previous file with comments | « services/shape_detection/public/interfaces/BUILD.gn ('k') | services/shape_detection/public/interfaces/facedetection.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698