RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2681913003
Cr-Commit-Position: refs/heads/master@{#450582}
Committed: https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac1964788e47c7

[junwei, 2017-02-08 01:37:17]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 01:38:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:38:16]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[junwei, 2017-02-08 01:52:02]

junwei.fu@intel.com changed reviewers:
+ dtrainor@chromium.org, haraken@chromium.org, leon.han@intel.com,
mcasas@chromium.org, rockot@chromium.org, tsepez@chromium.org,
xianglu@chromium.org

[mcasas, 2017-02-08 01:52:25]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[junwei, 2017-02-08 01:52:41]

On 2017/02/08 01:52:03, junwei.fu wrote:

PTAL.

[commit-bot: I haz the power, 2017-02-08 01:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-08 01:56:59]

The CQ bit was unchecked by junwei.fu@intel.com

[leonhsl(Using Gerrit), 2017-02-08 02:00:56]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 02:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-08 03:00:08]

Patchset #1 (id:1) has been deleted

[junwei, 2017-02-08 05:31:28]

Patchset #2 (id:40001) has been deleted

[junwei, 2017-02-08 05:40:08]

On 2017/02/08 01:52:41, junwei.fu wrote:
> On 2017/02/08 01:52:03, junwei.fu wrote:
> 
> PTAL.

TBR=leonhsl,Tom Sepez,haraken,David Trainor,Ken Rockot

[junwei, 2017-02-08 05:40:31]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 05:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 05:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 05:40:58]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[leonhsl(Using Gerrit), 2017-02-08 05:45:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 05:45:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-08 05:51:21]

The CQ bit was unchecked by junwei.fu@intel.com

[junwei, 2017-02-09 00:30:09]

On 2017/02/08 05:40:08, junwei.fu wrote:
> On 2017/02/08 01:52:41, junwei.fu wrote:
> > On 2017/02/08 01:52:03, junwei.fu wrote:
> > 
> > PTAL.
> 
> TBR=leonhsl,Tom Sepez,haraken,David Trainor,Ken Rockot

mcasas@,xianglu@ PTAL, thanks.

[haraken, 2017-02-09 00:47:43]

WebKit LGTM

[Tom Sepez, 2017-02-09 17:19:34]

mojom LGTM

[Ken Rockot(use gerrit already), 2017-02-09 17:19:53]

lgtm

[mcasas, 2017-02-10 16:03:02]

lgtm with a comment. Thanks!

https://codereview.chromium.org/2681913003/diff/60001/services/shape_detectio...
File services/shape_detection/detection_utils_mac.mm (right):

https://codereview.chromium.org/2681913003/diff/60001/services/shape_detectio...
services/shape_detection/detection_utils_mac.mm:32:
SkCreateCGImageRefWithColorspace(bitmap, colorspace));
Remove the reference to |colorspace| and pass NULL,
so the implementation can call [1]
CGColorSpaceCreateDeviceRGB() which is more robust 
that forcing SRGB 

[1]
https://cs.chromium.org/chromium/src/third_party/skia/include/utils/mac/SkCGU...

[junwei, 2017-02-11 06:32:02]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 06:32:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 08:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 08:30:35]

Dry run: This issue passed the CQ dry run.

[junwei, 2017-02-11 08:48:08]

The CQ bit was checked by junwei.fu@intel.com

[junwei, 2017-02-11 08:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
haraken@chromium.org, mcasas@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2681913003/#ps80001
(title: "RELAND: ShapeDetection: use mojom::Bitmap for mojo interface")

[commit-bot: I haz the power, 2017-02-11 08:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 08:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 08:54:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[junwei, 2017-02-11 08:59:09]

junwei.fu@intel.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[junwei, 2017-02-11 09:01:10]

David Trainor@ bsalomon@ reed1@ PTAL, thanks.

[David Trainor- moved to gerrit, 2017-02-13 22:03:18]

lgtm

[junwei, 2017-02-14 00:23:29]

The CQ bit was checked by junwei.fu@intel.com

[commit-bot: I haz the power, 2017-02-14 00:24:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-14 00:25:01]

The CQ bit was unchecked by junwei.fu@intel.com

[junwei, 2017-02-14 00:27:06]

The CQ bit was checked by junwei.fu@intel.com

[commit-bot: I haz the power, 2017-02-14 00:27:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 00:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 00:34:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[junwei, 2017-02-14 00:47:25]

On 2017/02/14 00:34:43, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

bsalomon@ reed1@ PTAL this file, thanks.
  services/shape_detection/DEPS

[bsalomon, 2017-02-14 02:12:49]

lgtm

[junwei, 2017-02-14 04:39:10]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
==========

to

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[junwei, 2017-02-14 04:39:35]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 04:40:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 05:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 05:02:55]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[junwei, 2017-02-14 05:45:21]

Patchset #4 (id:100001) has been deleted

[junwei, 2017-02-14 05:52:49]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 05:53:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 06:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 06:13:52]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[junwei, 2017-02-14 06:21:56]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 06:22:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-14 06:22:23]

Patchset #4 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-02-14 06:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 06:47:24]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[junwei, 2017-02-14 06:53:20]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 06:53:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-14 06:54:25]

Patchset #4 (id:140001) has been deleted

[commit-bot: I haz the power, 2017-02-14 07:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 07:02:26]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[junwei, 2017-02-14 08:22:17]

On 2017/02/14 02:12:49, bsalomon wrote:
> lgtm

mcasas@ PTAL these files, thanks:
  services/shape_detection/barcode_detection_impl_mac_unittest.mm
  services/shape_detection/face_detection_impl_mac_unittest.mm

[mcasas, 2017-02-14 16:55:52]

ps4 lgtm

-- also, try to give descriptive names to the different
patchsets, e.g. name the first one like the original
CL you're planning to reland:
"Original https://crrev.com/2629433003"
then PS4 like e.g.
"Rebase to https://crrev.com/2690253002"

[junwei, 2017-02-15 00:28:18]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 00:29:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-02-15 00:33:35]

Patchset #4 (id:160001) has been deleted

[commit-bot: I haz the power, 2017-02-15 03:50:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 03:50:25]

Dry run: This issue passed the CQ dry run.

[junwei, 2017-02-15 03:51:59]

The CQ bit was checked by junwei.fu@intel.com

[junwei, 2017-02-15 03:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dtrainor@chromium.org, haraken@chromium.org, bsalomon@google.com,
tsepez@chromium.org, mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2681913003/#ps180001
(title: "Rebase to https://codereview.chromium.org/2690253002/")

[commit-bot: I haz the power, 2017-02-15 03:53:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 06:10:27]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1487130719547510,
"parent_rev": "5da9a9aed98a274658b923478a68968f348ec5b5", "commit_rev":
"ab1a9331a441fa315edb669486ac1964788e47c7"}

[commit-bot: I haz the power, 2017-02-15 06:11:03]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2681913003
Cr-Commit-Position: refs/heads/master@{#450582}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac...
==========

[commit-bot: I haz the power, 2017-02-15 06:11:07]

Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac...

[perkj_chrome, 2017-02-15 07:34:21]

A revert of this CL (patchset #4 id:180001) has been created in
https://codereview.chromium.org/2696143002/ by perkj@chromium.org.

The reason for reverting is: Sorry - but this breaks blink layout tests on mac:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
.

[junwei, 2017-02-17 07:01:10]

On 2017/02/15 07:34:21, perkj_chrome wrote:
> A revert of this CL (patchset #4 id:180001) has been created in
> https://codereview.chromium.org/2696143002/ by mailto:perkj@chromium.org.
> 
> The reason for reverting is: Sorry - but this breaks blink layout tests on
mac:
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
> .
It can't be reproduced on my mac machine.
Any help would be great. 

Regressions: Unexpected timeouts (1)
  shapedetection/detection-on-worker.html [ Timeout ]

My testing logs:
$ python third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default 
shapedetection/detection-on-worker.html
Using port 'mac-retina'
Test configuration: <retina, x86, release>
View the test results at
file:///Users/web-team/junweifu/chromium/src/out/Default/layout-test-results/results.html
View the archived results dashboard at
file:///Users/web-team/junweifu/chromium/src/out/Default/layout-test-results/dashboard.html
Using random order with seed: 1487313317
Baseline search path: mac-retina -> mac -> generic
Using Release build
Pixel tests enabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /Users/web-team/junweifu/chromium/src/out/Default/Content
Shell.app/Contents/MacOS/Content Shell --run-layout-test -

Found 1 test; running 1, skipping 0.
                  
Running 1 Content Shell.                                                        
      

The test ran as expected.

[junwei, 2017-02-20 00:41:12]

Description was changed from

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2681913003
Cr-Commit-Position: refs/heads/master@{#450582}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac...
==========

to

==========
RELAND: ShapeDetection: use mojom::Bitmap for mojo interface.

Original CL got reverted due to conflit with another landed CL that need
to use mojom::bitmap.

Original CL description ------------------------------------------------
ShapeDetection: use mojom::Bitmap for mojo interface.

This CL uses mojo::Bitmap for mojo ShapeDetection interfaces definition,
so that the Detect API is completely flexible and friendly.

BUG=665488
TEST(Layout)=
 third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
 third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html

Review-Url: https://codereview.chromium.org/2629433003
Cr-Commit-Position: refs/heads/master@{#446142}
(cherry picked from commit 33adf4c85dd553eb607bcf9c02c5fa60c8738a68)

Conflicts:
	third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
	third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2681913003
Cr-Commit-Position: refs/heads/master@{#450582}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab1a9331a441fa315edb669486ac...
==========

[junwei, 2017-02-22 06:50:21]

mcasas@ xianglu@ Could you please help me to analyse these errors, thanks.

22:45:09.367 5988 worker/4 shapedetection/detection-on-worker.html output stderr
lines:
22:45:09.367 5988  
[10505:38915:0214/224503.384546:1238697160030:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
22:45:09.367 5988  
[10505:38915:0214/224503.384707:1238697318706:WARNING:url_request_job_manager.cc(90)]
Failed to map:
layout-test-mojom://content/shell/renderer/layout_test/interface_registry
22:45:09.367 5988  
[10508:775:0214/224503.391592:1238704207160:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/frame_interface_registry"
22:45:09.368 5988  
[10508:775:0214/224503.391666:1238704277865:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module
"content/shell/renderer/layout_test/interface_registry"
22:45:09.368 5988  
[10508:775:0214/224503.398271:1238710883225:ERROR:mojo_context_state.cc(199)]
Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
22:45:09.370 5941 [43111/48693] shapedetection/detection-on-worker.html failed
unexpectedly (test timed out)
22:45:09.368 5988 worker/4 killing primary driver
22:45:09.368 5988 worker/4 killing secondary driver
22:45:09.368 5988 worker/4 shapedetection/detection-on-worker.html failed:
22:45:09.369 5988 worker/4  test timed out

[mcasas, 2017-03-14 18:25:01]

On 2017/02/22 06:50:21, junwei.fu wrote:
> mcasas@ xianglu@ Could you please help me to analyse these errors, thanks.
> 
> 22:45:09.367 5988 worker/4 shapedetection/detection-on-worker.html output
stderr
> lines:
> 22:45:09.367 5988  
>
[10505:38915:0214/224503.384546:1238697160030:WARNING:url_request_job_manager.cc(90)]
> Failed to map:
>
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
> 22:45:09.367 5988  
>
[10505:38915:0214/224503.384707:1238697318706:WARNING:url_request_job_manager.cc(90)]
> Failed to map:
> layout-test-mojom://content/shell/renderer/layout_test/interface_registry
> 22:45:09.367 5988  
> [10508:775:0214/224503.391592:1238704207160:ERROR:mojo_context_state.cc(199)]
> Failed to fetch source for module
> "content/shell/renderer/layout_test/frame_interface_registry"
> 22:45:09.368 5988  
> [10508:775:0214/224503.391666:1238704277865:ERROR:mojo_context_state.cc(199)]
> Failed to fetch source for module
> "content/shell/renderer/layout_test/interface_registry"
> 22:45:09.368 5988  
> [10508:775:0214/224503.398271:1238710883225:ERROR:mojo_context_state.cc(199)]
> Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
> 22:45:09.370 5941 [43111/48693] shapedetection/detection-on-worker.html failed
> unexpectedly (test timed out)
> 22:45:09.368 5988 worker/4 killing primary driver
> 22:45:09.368 5988 worker/4 killing secondary driver
> 22:45:09.368 5988 worker/4 shapedetection/detection-on-worker.html failed:
> 22:45:09.369 5988 worker/4  test timed out

junwei.fu, what's the situation with this CL ?

[junwei, 2017-03-15 08:43:17]

junwei.fu@intel.com changed reviewers:
- leon.han@intel.com

[junwei, 2017-03-15 08:48:31]

On 2017/03/14 18:25:01, mcasas wrote:
> On 2017/02/22 06:50:21, junwei.fu wrote:
> > mcasas@ xianglu@ Could you please help me to analyse these errors, thanks.
> > 
> > 22:45:09.367 5988 worker/4 shapedetection/detection-on-worker.html output
> stderr
> > lines:
> > 22:45:09.367 5988  
> >
>
[10505:38915:0214/224503.384546:1238697160030:WARNING:url_request_job_manager.cc(90)]
> > Failed to map:
> >
>
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
> > 22:45:09.367 5988  
> >
>
[10505:38915:0214/224503.384707:1238697318706:WARNING:url_request_job_manager.cc(90)]
> > Failed to map:
> > layout-test-mojom://content/shell/renderer/layout_test/interface_registry
> > 22:45:09.367 5988  
> >
[10508:775:0214/224503.391592:1238704207160:ERROR:mojo_context_state.cc(199)]
> > Failed to fetch source for module
> > "content/shell/renderer/layout_test/frame_interface_registry"
> > 22:45:09.368 5988  
> >
[10508:775:0214/224503.391666:1238704277865:ERROR:mojo_context_state.cc(199)]
> > Failed to fetch source for module
> > "content/shell/renderer/layout_test/interface_registry"
> > 22:45:09.368 5988  
> >
[10508:775:0214/224503.398271:1238710883225:ERROR:mojo_context_state.cc(199)]
> > Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
> > 22:45:09.370 5941 [43111/48693] shapedetection/detection-on-worker.html
failed
> > unexpectedly (test timed out)
> > 22:45:09.368 5988 worker/4 killing primary driver
> > 22:45:09.368 5988 worker/4 killing secondary driver
> > 22:45:09.368 5988 worker/4 shapedetection/detection-on-worker.html failed:
> > 22:45:09.369 5988 worker/4  test timed out
> 
> junwei.fu, what's the situation with this CL ?

Unfortunately, the failed test case still can't be reproduced in my mac machine.

[junwei, 2017-03-16 06:36:02]

On 2017/03/15 08:48:31, junwei wrote:
> On 2017/03/14 18:25:01, mcasas wrote:
> > On 2017/02/22 06:50:21, junwei.fu wrote:
> > > mcasas@ xianglu@ Could you please help me to analyse these errors, thanks.
> > > 
> > > 22:45:09.367 5988 worker/4 shapedetection/detection-on-worker.html output
> > stderr
> > > lines:
> > > 22:45:09.367 5988  
> > >
> >
>
[10505:38915:0214/224503.384546:1238697160030:WARNING:url_request_job_manager.cc(90)]
> > > Failed to map:
> > >
> >
>
layout-test-mojom://content/shell/renderer/layout_test/frame_interface_registry
> > > 22:45:09.367 5988  
> > >
> >
>
[10505:38915:0214/224503.384707:1238697318706:WARNING:url_request_job_manager.cc(90)]
> > > Failed to map:
> > > layout-test-mojom://content/shell/renderer/layout_test/interface_registry
> > > 22:45:09.367 5988  
> > >
> [10508:775:0214/224503.391592:1238704207160:ERROR:mojo_context_state.cc(199)]
> > > Failed to fetch source for module
> > > "content/shell/renderer/layout_test/frame_interface_registry"
> > > 22:45:09.368 5988  
> > >
> [10508:775:0214/224503.391666:1238704277865:ERROR:mojo_context_state.cc(199)]
> > > Failed to fetch source for module
> > > "content/shell/renderer/layout_test/interface_registry"
> > > 22:45:09.368 5988  
> > >
> [10508:775:0214/224503.398271:1238710883225:ERROR:mojo_context_state.cc(199)]
> > > Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
> > > 22:45:09.370 5941 [43111/48693] shapedetection/detection-on-worker.html
> failed
> > > unexpectedly (test timed out)
> > > 22:45:09.368 5988 worker/4 killing primary driver
> > > 22:45:09.368 5988 worker/4 killing secondary driver
> > > 22:45:09.368 5988 worker/4 shapedetection/detection-on-worker.html failed:
> > > 22:45:09.369 5988 worker/4  test timed out
> > 
> > junwei.fu, what's the situation with this CL ?
> 
> Unfortunately, the failed test case still can't be reproduced in my mac
machine.

Sam McNally@ could you please help me to analyse the failed messages?
> Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"

[junwei, 2017-03-16 08:06:06]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:06:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 08:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 08:16:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[junwei, 2017-03-16 08:21:30]

Patchset #5 (id:200001) has been deleted

[junwei, 2017-03-16 08:24:01]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 08:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 08:34:38]

Dry run: Exceeded global retry quota

[junwei, 2017-03-16 08:45:55]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:46:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-16 08:46:37]

Patchset #5 (id:220001) has been deleted

[leonhsl(Using Gerrit), 2017-03-16 09:14:08]

leon.han@intel.com changed reviewers:
+ leon.han@intel.com

[leonhsl(Using Gerrit), 2017-03-16 09:14:09]

Hi, a question maybe unrelates with this CL:
Given the fact that shape_detection::mojom::FaceDetectionProvider interface is
hosted in shape_detection service, why Blink is using
Platform::current()->interfaceProvider() to bind it? Should Blink connect to
shape_detection service to bind this interface? Thanks!

[commit-bot: I haz the power, 2017-03-16 10:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 10:47:03]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-03-16 13:09:04]

On Mar 16, 2017 2:14 AM, <leon.han@intel.com> wrote:

Hi, a question maybe unrelates with this CL:
Given the fact that shape_detection::mojom::FaceDetectionProvider interface
is
hosted in shape_detection service, why Blink is using
Platform::current()->interfaceProvider() to bind it? Should Blink connect to
shape_detection service to bind this interface? Thanks!


Two reasons, I think: it started as a stopgap from when singleton services
weren't packaged in the browser properly, and now it remains because we're
still waiting on ServiceConnector support for overriding services in layout
tests.


https://codereview.chromium.org/2681913003/

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Ken Rockot(use gerrit already), 2017-03-16 13:09:04]

On Mar 16, 2017 2:14 AM, <leon.han@intel.com> wrote:

Hi, a question maybe unrelates with this CL:
Given the fact that shape_detection::mojom::FaceDetectionProvider interface
is
hosted in shape_detection service, why Blink is using
Platform::current()->interfaceProvider() to bind it? Should Blink connect to
shape_detection service to bind this interface? Thanks!


Two reasons, I think: it started as a stopgap from when singleton services
weren't packaged in the browser properly, and now it remains because we're
still waiting on ServiceConnector support for overriding services in layout
tests.


https://codereview.chromium.org/2681913003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[junwei, 2017-03-17 00:48:02]

junwei.fu@intel.com changed reviewers:
+ sammc@chromium.org

[junwei, 2017-03-17 00:53:29]

> Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"

Sam McNally@ could you please help me analyse the error message that only failed
in try bots after landing the cl?

[Sam McNally, 2017-03-17 01:37:07]

On 2017/03/17 00:53:29, junwei wrote:
> > Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
> 
> Sam McNally@ could you please help me analyse the error message that only
failed
> in try bots after landing the cl?

It looks like the generated JS bindings for skia/public/interfaces/bitmap.mojom
aren't included in the archive. This would likely be due to missing dependencies
from layout tests on the bindings. See
https://codereview.chromium.org/2742793003 for a fix for a similar issue.

[junwei, 2017-03-17 02:08:01]

On 2017/03/17 01:37:07, Sam McNally wrote:
> On 2017/03/17 00:53:29, junwei wrote:
> > > Failed to fetch source for module "skia/public/interfaces/bitmap.mojom"
> > 
> > Sam McNally@ could you please help me analyse the error message that only
> failed
> > in try bots after landing the cl?
> 
> It looks like the generated JS bindings for
skia/public/interfaces/bitmap.mojom
> aren't included in the archive. This would likely be due to missing
dependencies
> from layout tests on the bindings. See
> https://codereview.chromium.org/2742793003 for a fix for a similar issue.

Sam McNally@ thank you very much.

[junwei, 2017-03-17 02:09:37]

mcasas@ should i skip the failed test case in the cl, and then anther cl for
passing layout tests.

[junwei, 2017-03-17 02:20:37]

On 2017/03/17 02:09:37, junwei wrote:
> mcasas@ should i skip the failed test case in the cl, and then anther cl for
> passing layout tests.

Because it can be reproduced both local testing and presubmit try bots, i'm not
sure if it's fixed.

[junwei, 2017-03-17 05:28:50]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 05:29:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[junwei, 2017-03-17 05:30:07]

junwei.fu@intel.com changed reviewers:
+ dpranke@chromium.org

[junwei, 2017-03-17 05:33:37]

Dirk Pranke@ PTAL BUILD.gn that is fix the issue of failing to fetch
bitmap.mojom module.

[junwei, 2017-03-17 05:58:54]

Patchset #6 (id:260001) has been deleted

[junwei, 2017-03-17 05:59:04]

The CQ bit was checked by junwei.fu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 05:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 07:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 07:38:53]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-03-17 17:09:52]

On 2017/03/17 05:33:37, junwei wrote:
> Dirk Pranke@ PTAL BUILD.gn that is fix the issue of failing to fetch
> bitmap.mojom module.

junwei.fu: this CL is closed. You'll have to open another one,
upload the latest landed and reverted CL as PS1, labelling it
accordingly, then add the changes in subsequent PSs (see
e.g. https://codereview.chromium.org/2756793002/).

We might need another review since text_detection is new.

[Dirk Pranke, 2017-03-19 21:05:58]

lgtm

[Ken Rockot(use gerrit already), 2017-03-24 21:22:37]

rockot@chromium.org changed reviewers:
- rockot@chromium.org

[Dirk Pranke, 2017-07-15 22:09:19]

Rietveld cleanup time ...

I think this CL is obsolete since we've landed and reverted newer versions,
e.g.: https://codereview.chromium.org/2681913003 . So, I'm closing this. If this
is still needed, please move it to Gerrit.