Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: services/shape_detection/text_detection_impl_mac.mm

Issue 2875243002: RELAND: ShapeDetection: use mojom::Bitmap for mojo interface. (Closed)
Patch Set: RELAND2: ShapeDetection: use mojom::Bitmap for mojo interface. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/shape_detection/text_detection_impl_mac.mm
diff --git a/services/shape_detection/text_detection_impl_mac.mm b/services/shape_detection/text_detection_impl_mac.mm
index 95ca50af4e17838288af22a51bd99f47d24665c5..b47744eb1baccb614159bb489fd8c8b7725c5f8f 100644
--- a/services/shape_detection/text_detection_impl_mac.mm
+++ b/services/shape_detection/text_detection_impl_mac.mm
@@ -50,22 +50,20 @@ TextDetectionImplMac::TextDetectionImplMac() {
TextDetectionImplMac::~TextDetectionImplMac() {}
-void TextDetectionImplMac::Detect(mojo::ScopedSharedBufferHandle frame_data,
- uint32_t width,
- uint32_t height,
+void TextDetectionImplMac::Detect(const SkBitmap& bitmap,
const DetectCallback& callback) {
DCHECK(base::mac::IsAtLeastOS10_11());
media::ScopedResultCallback<DetectCallback> scoped_callback(
base::Bind(&RunCallbackWithResults, callback),
base::Bind(&RunCallbackWithNoResults));
- base::scoped_nsobject<CIImage> ci_image =
- CreateCIImageFromSharedMemory(std::move(frame_data), width, height);
+ base::scoped_nsobject<CIImage> ci_image = CreateCIImageFromSkBitmap(bitmap);
if (!ci_image)
return;
NSArray* const features = [detector_ featuresInImage:ci_image];
+ const int height = bitmap.height();
std::vector<mojom::TextDetectionResultPtr> results;
for (CIRectangleFeature* const f in features) {
// CIRectangleFeature only has bounding box information.
« no previous file with comments | « services/shape_detection/text_detection_impl_mac.h ('k') | services/shape_detection/text_detection_impl_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698