Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2873433003: Move MediaQuery classes off BlinkGC heap (Closed)

Created:
3 years, 7 months ago by keishi
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, kozyatinskiy+blink_chromium.org, blink-reviews-css, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, caseq+blink_chromium.org, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, devtools-reviews_chromium.org, rwlbuis
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Move MediaQuery classes off BlinkGC heap This CL moves the following classes off the BlinkGC heap MediaQueryExp MediaQuery MediaQuerySet MediaQueryResult in an effort to avoid the crasher crbug.com/699269. BUG=699269 Review-Url: https://codereview.chromium.org/2837023005 Cr-Commit-Position: refs/heads/master@{#467331} (cherry picked from commit d434dda595a984d1d39697d991ef03626c55b041 Review-Url: https://codereview.chromium.org/2873433003 . Cr-Commit-Position: refs/branch-heads/3029@{#828} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c831ce8658049391077c041726806df2422f037f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -216 lines) Patch
M third_party/WebKit/Source/core/css/CSSMediaRule.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSMediaRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.h View 4 chunks +22 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.cpp View 9 chunks +19 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.h View 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.cpp View 4 chunks +17 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 3 chunks +20 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.h View 2 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcherTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuerySetTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleMedia.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MediaQueryResult.h View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 5 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
keishi
3 years, 7 months ago (2017-05-08 22:23:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c831ce8658049391077c041726806df2422f037f (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698