Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2837023005: Move MediaQuery classes off BlinkGC heap (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, kozyatinskiy+blink_chromium.org, blink-reviews-css, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, caseq+blink_chromium.org, apavlov+blink_chromium.org, darktears, blink-reviews, kinuko+watch, devtools-reviews_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaQuery classes off BlinkGC heap This CL moves the following classes off the BlinkGC heap MediaQueryExp MediaQuery MediaQuerySet MediaQueryResult in an effort to avoid the crasher crbug.com/699269. BUG=699269 Review-Url: https://codereview.chromium.org/2837023005 Cr-Commit-Position: refs/heads/master@{#467331} Committed: https://chromium.googlesource.com/chromium/src/+/d434dda595a984d1d39697d991ef03626c55b041

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Total comments: 4

Patch Set 4 : fix #

Total comments: 6

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -230 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSMediaRule.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSMediaRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.h View 1 2 3 3 chunks +24 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.cpp View 1 2 3 11 chunks +19 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.h View 1 2 3 4 2 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.cpp View 1 2 3 4 4 chunks +18 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 2 4 chunks +19 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.h View 1 2 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcherTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuerySetTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleMedia.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.h View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp View 1 3 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MediaQueryResult.h View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp View 1 2 5 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
keishi
It looks like none of my CHECKs worked. This CL moves MediaQuery related classes off ...
3 years, 8 months ago (2017-04-26 08:52:14 UTC) #6
haraken
The approach looks good. - Avoid using PassRefPtr since we're deprecating it. - Add std::move() ...
3 years, 8 months ago (2017-04-26 09:09:32 UTC) #8
sof
https://codereview.chromium.org/2837023005/diff/20002/third_party/WebKit/Source/core/css/MediaQuery.cpp File third_party/WebKit/Source/core/css/MediaQuery.cpp (right): https://codereview.chromium.org/2837023005/diff/20002/third_party/WebKit/Source/core/css/MediaQuery.cpp#newcode102 third_party/WebKit/Source/core/css/MediaQuery.cpp:102: CHECK(String() == String()); accidental addition?
3 years, 8 months ago (2017-04-26 09:16:12 UTC) #10
keishi
Removed PassRefPtr https://codereview.chromium.org/2837023005/diff/20002/third_party/WebKit/Source/core/css/MediaList.h File third_party/WebKit/Source/core/css/MediaList.h (right): https://codereview.chromium.org/2837023005/diff/20002/third_party/WebKit/Source/core/css/MediaList.h#newcode84 third_party/WebKit/Source/core/css/MediaList.h:84: return new MediaList(media_queries, parent_rule); On 2017/04/26 09:09:32, ...
3 years, 8 months ago (2017-04-26 09:44:35 UTC) #11
haraken
LGTM https://codereview.chromium.org/2837023005/diff/50001/third_party/WebKit/Source/core/css/MediaQuery.cpp File third_party/WebKit/Source/core/css/MediaQuery.cpp (right): https://codereview.chromium.org/2837023005/diff/50001/third_party/WebKit/Source/core/css/MediaQuery.cpp#newcode77 third_party/WebKit/Source/core/css/MediaQuery.cpp:77: return WTF::WrapUnique(new MediaQuery(MediaQuery::kNot, MediaTypeNames::all, MakeUnique. https://codereview.chromium.org/2837023005/diff/50001/third_party/WebKit/Source/core/css/MediaQuery.cpp#newcode85 third_party/WebKit/Source/core/css/MediaQuery.cpp:85: return ...
3 years, 8 months ago (2017-04-26 11:15:25 UTC) #12
keishi
https://codereview.chromium.org/2837023005/diff/50001/third_party/WebKit/Source/core/css/MediaQuery.cpp File third_party/WebKit/Source/core/css/MediaQuery.cpp (right): https://codereview.chromium.org/2837023005/diff/50001/third_party/WebKit/Source/core/css/MediaQuery.cpp#newcode77 third_party/WebKit/Source/core/css/MediaQuery.cpp:77: return WTF::WrapUnique(new MediaQuery(MediaQuery::kNot, MediaTypeNames::all, On 2017/04/26 11:15:25, haraken wrote: ...
3 years, 8 months ago (2017-04-26 13:28:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837023005/70001
3 years, 8 months ago (2017-04-26 13:29:19 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 15:46:13 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/d434dda595a984d1d39697d991ef...

Powered by Google App Engine
This is Rietveld 408576698