Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp

Issue 2873433003: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
index 3709e4a2028f44986229e34fc2f2a98a5c3fc5dc..6c4baedd9f211c1a6bed46b96ca5e37c836ff308 100644
--- a/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp
@@ -53,7 +53,7 @@ bool SizesAttributeParser::calculateLengthInPixels(CSSParserTokenRange range,
}
bool SizesAttributeParser::mediaConditionMatches(
- MediaQuerySet* mediaCondition) {
+ const MediaQuerySet& mediaCondition) {
// A Media Condition cannot have a media type other then screen.
MediaQueryEvaluator mediaQueryEvaluator(*m_mediaValues);
return mediaQueryEvaluator.eval(mediaCondition);
@@ -80,9 +80,10 @@ bool SizesAttributeParser::parse(CSSParserTokenRange range) {
if (!calculateLengthInPixels(
range.makeSubRange(lengthTokenStart, lengthTokenEnd), length))
continue;
- MediaQuerySet* mediaCondition = MediaQueryParser::parseMediaCondition(
- range.makeSubRange(mediaConditionStart, lengthTokenStart));
- if (!mediaCondition || !mediaConditionMatches(mediaCondition))
+ RefPtr<MediaQuerySet> mediaCondition =
+ MediaQueryParser::parseMediaCondition(
+ range.makeSubRange(mediaConditionStart, lengthTokenStart));
+ if (!mediaCondition || !mediaConditionMatches(*mediaCondition))
continue;
m_length = length;
m_lengthWasSet = true;

Powered by Google App Engine
This is Rietveld 408576698