third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp - Issue 2873433003: Move MediaQuery classes off BlinkGC heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp

Issue 2873433003: Move MediaQuery classes off BlinkGC heap (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp b/third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp

index 2ebb730a505d53e413e972873d6a19b1cee74201..bce819ab3497dced6e0708dabe6ca8ea4894fc4f 100644

--- a/third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp

+++ b/third_party/WebKit/Source/core/css/parser/MediaConditionTest.cpp

@@ -38,7 +38,7 @@ TEST(MediaConditionParserTest, Basic) {

// FIXME: We should test comma-seperated media conditions

for (unsigned i = 0; testCases[i].input; ++i) {

CSSTokenizer tokenizer(testCases[i].input);

- MediaQuerySet* mediaConditionQuerySet =

+ RefPtr<MediaQuerySet> mediaConditionQuerySet =

MediaQueryParser::parseMediaCondition(tokenizer.tokenRange());

ASSERT_EQ(mediaConditionQuerySet->queryVector().size(), (unsigned)1);

String queryText = mediaConditionQuerySet->queryVector()[0]->cssText();