third_party/WebKit/Source/core/html/LinkStyle.cpp - Issue 2873433003: Move MediaQuery classes off BlinkGC heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/LinkStyle.cpp

Issue 2873433003: Move MediaQuery classes off BlinkGC heap (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/LinkStyle.cpp

diff --git a/third_party/WebKit/Source/core/html/LinkStyle.cpp b/third_party/WebKit/Source/core/html/LinkStyle.cpp

index 2dc4d0b15e12489cf326ffaeee026da6b6bd8092..3f2bef5d3a6eda980f06d5040570e36630491446 100644

--- a/third_party/WebKit/Source/core/html/LinkStyle.cpp

+++ b/third_party/WebKit/Source/core/html/LinkStyle.cpp

@@ -313,9 +313,9 @@ LinkStyle::LoadReturnValue LinkStyle::loadStylesheetIfNeeded(

bool mediaQueryMatches = true;

LocalFrame* frame = loadingFrame();

if (!m_owner->media().isEmpty() && frame) {

- MediaQuerySet* media = MediaQuerySet::create(m_owner->media());

+ RefPtr<MediaQuerySet> media = MediaQuerySet::create(m_owner->media());

MediaQueryEvaluator evaluator(frame);

- mediaQueryMatches = evaluator.eval(media);

+ mediaQueryMatches = evaluator.eval(*media);

}

// Don't hold up layout tree construction and script execution on