Move MediaQuery classes off BlinkGC heap

third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

 /*
  * CSS Media Query Evaluator
  *
  * Copyright (C) 2006 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 93 matching lines @@
   return mediaTypeToMatch.isEmpty() ||
          equalIgnoringCase(mediaTypeToMatch, MediaTypeNames::all) ||
          equalIgnoringCase(mediaTypeToMatch, mediaType());
 }
 
 static bool applyRestrictor(MediaQuery::RestrictorType r, bool value) {
   return r == MediaQuery::Not ? !value : value;
 }
 
 bool MediaQueryEvaluator::eval(
-    const MediaQuery* query,
+    const MediaQuery& query,
     MediaQueryResultList* viewportDependentMediaQueryResults,
     MediaQueryResultList* deviceDependentMediaQueryResults) const {
-  if (!mediaTypeMatch(query->mediaType()))
-    return applyRestrictor(query->restrictor(), false);
+  if (!mediaTypeMatch(query.mediaType()))
+    return applyRestrictor(query.restrictor(), false);
 
-  const ExpressionHeapVector& expressions = query->expressions();
+  const ExpressionHeapVector& expressions = query.expressions();
   // Iterate through expressions, stop if any of them eval to false (AND
   // semantics).
   size_t i = 0;
   for (; i < expressions.size(); ++i) {
-    bool exprResult = eval(expressions.at(i).get());
+    bool exprResult = eval(expressions.at(i));
     if (viewportDependentMediaQueryResults &&
-        expressions.at(i)->isViewportDependent())
+        expressions.at(i).isViewportDependent()) {
       viewportDependentMediaQueryResults->push_back(
-          new MediaQueryResult(*expressions.at(i), exprResult));
+          MediaQueryResult(expressions.at(i), exprResult));
+    }
     if (deviceDependentMediaQueryResults &&
-        expressions.at(i)->isDeviceDependent())
+        expressions.at(i).isDeviceDependent()) {
       deviceDependentMediaQueryResults->push_back(
-          new MediaQueryResult(*expressions.at(i), exprResult));
+          MediaQueryResult(expressions.at(i), exprResult));
+    }
     if (!exprResult)
       break;
   }
 
   // Assume true if we are at the end of the list, otherwise assume false.
-  return applyRestrictor(query->restrictor(), expressions.size() == i);
+  return applyRestrictor(query.restrictor(), expressions.size() == i);
 }
 
 bool MediaQueryEvaluator::eval(
-    const MediaQuerySet* querySet,
+    const MediaQuerySet& querySet,
     MediaQueryResultList* viewportDependentMediaQueryResults,
     MediaQueryResultList* deviceDependentMediaQueryResults) const {
-  if (!querySet)
-    return true;
-
-  const HeapVector<Member<MediaQuery>>& queries = querySet->queryVector();
+  const Vector<std::unique_ptr<MediaQuery>>& queries = querySet.queryVector();
   if (!queries.size())
     return true;  // Empty query list evaluates to true.
 
   // Iterate over queries, stop if any of them eval to true (OR semantics).
   bool result = false;
-  for (size_t i = 0; i < queries.size() && !result; ++i)
-    result = eval(queries[i].get(), viewportDependentMediaQueryResults,
+  for (size_t i = 0; i < queries.size() && !result; ++i) {
+    result = eval(*queries[i], viewportDependentMediaQueryResults,
                   deviceDependentMediaQueryResults);
-
+  }
   return result;
 }
 
 template <typename T>
 bool compareValue(T a, T b, MediaFeaturePrefix op) {
   switch (op) {
     case MinPrefix:
       return a >= b;
     case MaxPrefix:
       return a <= b;
@@ skipping 633 matching lines @@
 
 void MediaQueryEvaluator::init() {
   // Create the table.
   gFunctionMap = new FunctionMap;
 #define ADD_TO_FUNCTIONMAP(name) \
   gFunctionMap->set(name##MediaFeature.impl(), name##MediaFeatureEval);
   CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(ADD_TO_FUNCTIONMAP);
 #undef ADD_TO_FUNCTIONMAP
 }
 
-bool MediaQueryEvaluator::eval(const MediaQueryExp* expr) const {
+bool MediaQueryEvaluator::eval(const MediaQueryExp& expr) const {
   if (!m_mediaValues || !m_mediaValues->hasValues())
     return true;
 
   DCHECK(gFunctionMap);
 
   // Call the media feature evaluation function. Assume no prefix and let
   // trampoline functions override the prefix if prefix is used.
-  EvalFunc func = gFunctionMap->at(expr->mediaFeature().impl());
+  EvalFunc func = gFunctionMap->at(expr.mediaFeature().impl());
   if (func)
-    return func(expr->expValue(), NoPrefix, *m_mediaValues);
+    return func(expr.expValue(), NoPrefix, *m_mediaValues);
 
   return false;
 }
 
 }  // namespace blink