Tweak PaintInvalidationReasons

Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange,
    etc. --> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2 (e.g. a layout test produced difference
  about "bounds change" vs "location change" for spv1 vs spv2, and
  now the difference is eliminated).
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2872423002
Cr-Commit-Position: refs/heads/master@{#471600}
Committed: https://chromium.googlesource.com/chromium/src/+/d6bd864741d33ff3726227ab5dc688377c1b350e

[Xianzhu, 2017-05-10 23:18:44]

Description was changed from

==========
Tweak PaintInvalidatinReason
==========

to

==========
Tweak PaintInvalidatinReason
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-10 23:23:13]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 23:24:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:46:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:46:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-05-11 17:49:00]

Description was changed from

==========
Tweak PaintInvalidatinReason
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange, etc.
--> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2.
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-11 18:47:10]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 18:48:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 20:09:15]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2017-05-11 22:56:08]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 22:57:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 23:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 23:46:42]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2017-05-12 18:23:07]

Description was changed from

==========
Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange, etc.
--> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2.
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange,
    etc. --> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2 (e.g. a layout test produced difference
  about "bounds change" vs "location change" for spv1 vs spv2, and
  now the difference is eliminated).
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-05-12 18:23:25]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[chrishtr, 2017-05-12 22:06:36]

lgtm

[Xianzhu, 2017-05-13 00:03:01]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-13 00:03:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 02:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 02:13:30]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-05-13 02:38:21]

LGTM 2

[Xianzhu, 2017-05-13 04:44:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-13 04:44:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2872423002/#ps90001
(title: "Rebaseline-cl")

[commit-bot: I haz the power, 2017-05-13 04:45:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 06:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 07:00:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2017-05-13 16:37:00]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-13 16:37:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 19:21:46]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1494693420507050,
"parent_rev": "82afc22a4146e58caddfb33496c1ff3e15307854", "commit_rev":
"d6bd864741d33ff3726227ab5dc688377c1b350e"}

[commit-bot: I haz the power, 2017-05-13 19:22:00]

Description was changed from

==========
Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange,
    etc. --> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2 (e.g. a layout test produced difference
  about "bounds change" vs "location change" for spv1 vs spv2, and
  now the difference is eliminated).
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Tweak PaintInvalidationReasons

- Change the enum type to an enum class;
- Combine some reasons
  - BoundsChange, LocationChange, BorderBoxChange, LayoutOverflowChange,
    etc. --> PaintInvalidationReason::kGeometry
  - etc.
  This is to reduce ambiguity of the reasons, and reduce differences
  between spv1 and spv2 (e.g. a layout test produced difference
  about "bounds change" vs "location change" for spv1 vs spv2, and
  now the difference is eliminated).
- Add some reasons (kImage, etc.) that may be useful for debugging.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2872423002
Cr-Commit-Position: refs/heads/master@{#471600}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6bd864741d33ff3726227ab5dc6...
==========

[commit-bot: I haz the power, 2017-05-13 19:22:08]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/d6bd864741d33ff3726227ab5dc6...