Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp

Issue 2872423002: Tweak PaintInvalidationReasons (Closed)
Patch Set: Rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
index d8daf48d2deecf8b798c087804150a6b4f5c84b7..95bc174068acdc4cb8278061ba08564239699a66 100644
--- a/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/TableCellPaintInvalidator.cpp
@@ -22,17 +22,18 @@ PaintInvalidationReason TableCellPaintInvalidator::InvalidatePaint() {
if (context_.old_location != context_.new_location ||
cell_.Size() != cell_.PreviousSize()) {
const auto& row = *cell_.Row();
- if (row.GetPaintInvalidationReason() == kPaintInvalidationNone &&
+ if (row.GetPaintInvalidationReason() == PaintInvalidationReason::kNone &&
row.StyleRef().HasBackground()) {
if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
context_.parent_context->painting_layer->SetNeedsRepaint();
else
ObjectPaintInvalidator(row).SlowSetPaintingLayerNeedsRepaint();
- row.InvalidateDisplayItemClients(kPaintInvalidationForcedByLayout);
+ row.InvalidateDisplayItemClients(PaintInvalidationReason::kGeometry);
}
const auto& section = *row.Section();
- if (section.GetPaintInvalidationReason() == kPaintInvalidationNone) {
+ if (section.GetPaintInvalidationReason() ==
+ PaintInvalidationReason::kNone) {
bool section_paints_background = section.StyleRef().HasBackground();
if (!section_paints_background) {
auto col_and_colgroup = section.Table()->ColElementAtAbsoluteColumn(
@@ -50,7 +51,8 @@ PaintInvalidationReason TableCellPaintInvalidator::InvalidatePaint() {
} else {
ObjectPaintInvalidator(section).SlowSetPaintingLayerNeedsRepaint();
}
- section.InvalidateDisplayItemClients(kPaintInvalidationForcedByLayout);
+ section.InvalidateDisplayItemClients(
+ PaintInvalidationReason::kGeometry);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698