Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp

Issue 2872423002: Tweak PaintInvalidationReasons (Closed)
Patch Set: Rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
index f3654483cdfb5c42aded6e3bf61e2f1afa95fa5b..dcb42f70643e61b7f68c0198020f2553144a6bc8 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidationTest.cpp
@@ -174,15 +174,15 @@ TEST_P(PaintInvalidationTest, DelayedFullPaintInvalidation) {
auto* target = GetLayoutObjectByElementId("target");
target->SetShouldDoFullPaintInvalidationWithoutGeometryChange(
- kPaintInvalidationDelayedFull);
- EXPECT_EQ(kPaintInvalidationDelayedFull,
+ PaintInvalidationReason::kDelayedFull);
+ EXPECT_EQ(PaintInvalidationReason::kDelayedFull,
target->FullPaintInvalidationReason());
EXPECT_FALSE(target->NeedsPaintOffsetAndVisualRectUpdate());
GetDocument().View()->SetTracksPaintInvalidations(true);
GetDocument().View()->UpdateAllLifecyclePhases();
EXPECT_EQ(nullptr, GetRasterInvalidationTracking());
- EXPECT_EQ(kPaintInvalidationDelayedFull,
+ EXPECT_EQ(PaintInvalidationReason::kDelayedFull,
target->FullPaintInvalidationReason());
EXPECT_FALSE(target->NeedsPaintOffsetAndVisualRectUpdate());
GetDocument().View()->SetTracksPaintInvalidations(false);
@@ -194,9 +194,10 @@ TEST_P(PaintInvalidationTest, DelayedFullPaintInvalidation) {
const auto& raster_invalidations =
GetRasterInvalidationTracking()->invalidations;
ASSERT_EQ(1u, raster_invalidations.size());
- EXPECT_EQ(kPaintInvalidationNone, target->FullPaintInvalidationReason());
+ EXPECT_EQ(PaintInvalidationReason::kNone,
+ target->FullPaintInvalidationReason());
EXPECT_EQ(IntRect(0, 4000, 100, 100), raster_invalidations[0].rect);
- EXPECT_EQ(kPaintInvalidationFull, raster_invalidations[0].reason);
+ EXPECT_EQ(PaintInvalidationReason::kFull, raster_invalidations[0].reason);
EXPECT_FALSE(target->NeedsPaintOffsetAndVisualRectUpdate());
GetDocument().View()->SetTracksPaintInvalidations(false);
};

Powered by Google App Engine
This is Rietveld 408576698