Tweak PaintInvalidationReasons

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1688 matching lines @@
         GetLayoutView()->SetShouldDoFullPaintInvalidationOnResizeIfNeeded(
             width_changed, height_changed);
       }
     } else if (height_changed) {
       // If the document rect doesn't fill the full view height, hiding the
       // URL bar will expose area outside the current LayoutView so we need to
       // paint additional background. If RLS is on, we've already invalidated
       // above.
       LayoutViewItem lvi = GetLayoutViewItem();
       DCHECK(!lvi.IsNull());
-      if (lvi.DocumentRect().Height() < lvi.ViewRect().Height())
-        lvi.SetShouldDoFullPaintInvalidation();
+      if (lvi.DocumentRect().Height() < lvi.ViewRect().Height()) {
+        lvi.SetShouldDoFullPaintInvalidation(
+            PaintInvalidationReason::kGeometry);
+      }
     }
   }
 
   if (GetFrame().GetDocument() && !IsInPerformLayout())
     MarkViewportConstrainedObjectsForLayout(width_changed, height_changed);
 }
 
 void FrameView::MarkViewportConstrainedObjectsForLayout(bool width_changed,
                                                         bool height_changed) {
   if (!HasViewportConstrainedObjects() || !(width_changed || height_changed))
@@ skipping 32 matching lines @@
          !frame_->GetEventHandler().IsMousePositionUnknown() &&
          page->GetFocusController().IsActive();
 }
 
 void FrameView::ScrollContentsIfNeededRecursive() {
   ForAllNonThrottledFrameViews(
       [](FrameView& frame_view) { frame_view.ScrollContentsIfNeeded(); });
 }
 
 void FrameView::InvalidateBackgroundAttachmentFixedObjects() {
-  for (const auto& layout_object : background_attachment_fixed_objects_)
-    layout_object->SetShouldDoFullPaintInvalidation();
+  for (const auto& layout_object : background_attachment_fixed_objects_) {
+    layout_object->SetShouldDoFullPaintInvalidation(
+        PaintInvalidationReason::kBackground);
+  }
 }
 
 bool FrameView::HasBackgroundAttachmentFixedDescendants(
     const LayoutObject& object) const {
   for (const auto* potential_descendant :
        background_attachment_fixed_objects_) {
     if (potential_descendant == &object)
       continue;
     if (potential_descendant->IsDescendantOf(&object))
       return true;
@@ skipping 1698 matching lines @@
       // Thus we have to check that it makes sense to do paint
       // invalidation onto them here.
       if (!child_frame_view.GetLayoutView())
         continue;
       child_frame_view.DeprecatedInvalidateTreeRecursiveInternal();
     }
   }
 
   // Process objects needing paint invalidation on the next frame. See the
   // definition of PaintInvalidationDelayedFull for more details.
-  for (auto& target : pending_delayed_paint_invalidations)
+  for (auto& target : pending_delayed_paint_invalidations) {
     target->GetMutableForPainting().SetShouldDoFullPaintInvalidation(
-        kPaintInvalidationDelayedFull);
+        PaintInvalidationReason::kDelayedFull);
+  }
 }
 
 void FrameView::EnableAutoSizeMode(const IntSize& min_size,
                                    const IntSize& max_size) {
   if (!auto_size_info_)
     auto_size_info_ = FrameViewAutoSizeInfo::Create(this);
 
   auto_size_info_->ConfigureAutoSizeMode(min_size, max_size);
   SetLayoutSizeFixedToFrameSize(true);
   SetNeedsLayout();
@@ skipping 1866 matching lines @@
 void FrameView::SetAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   animation_host_ = std::move(host);
 }
 
 LayoutUnit FrameView::CaretWidth() const {
   return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
 }
 
 }  // namespace blink