Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2872423002: Tweak PaintInvalidationReasons (Closed)
Patch Set: Rebaseline-cl Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 // the 'root' i.e. html or body) as the background positioning area, and we 234 // the 'root' i.e. html or body) as the background positioning area, and we
235 // should fully invalidate on viewport resize if the background image is not 235 // should fully invalidate on viewport resize if the background image is not
236 // composited and needs full paint invalidation on background positioning area 236 // composited and needs full paint invalidation on background positioning area
237 // resize. 237 // resize.
238 if (Style()->HasFixedBackgroundImage() && 238 if (Style()->HasFixedBackgroundImage() &&
239 (!compositor_ || !compositor_->NeedsFixedRootBackgroundLayer(Layer()))) { 239 (!compositor_ || !compositor_->NeedsFixedRootBackgroundLayer(Layer()))) {
240 if ((width_changed && MustInvalidateFillLayersPaintOnWidthChange( 240 if ((width_changed && MustInvalidateFillLayersPaintOnWidthChange(
241 Style()->BackgroundLayers())) || 241 Style()->BackgroundLayers())) ||
242 (height_changed && MustInvalidateFillLayersPaintOnHeightChange( 242 (height_changed && MustInvalidateFillLayersPaintOnHeightChange(
243 Style()->BackgroundLayers()))) 243 Style()->BackgroundLayers())))
244 SetShouldDoFullPaintInvalidation(kPaintInvalidationBoundsChange); 244 SetShouldDoFullPaintInvalidation(PaintInvalidationReason::kBackground);
245 } 245 }
246 } 246 }
247 247
248 void LayoutView::UpdateLayout() { 248 void LayoutView::UpdateLayout() {
249 if (!GetDocument().Paginated()) 249 if (!GetDocument().Paginated())
250 SetPageLogicalHeight(LayoutUnit()); 250 SetPageLogicalHeight(LayoutUnit());
251 251
252 // TODO(wangxianzhu): Move this into ViewPaintInvalidator when 252 // TODO(wangxianzhu): Move this into ViewPaintInvalidator when
253 // rootLayerScrolling is permanently enabled. 253 // rootLayerScrolling is permanently enabled.
254 IncludeScrollbarsInRect include_scrollbars = 254 IncludeScrollbarsInRect include_scrollbars =
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 // Frame scroll corner is painted using LayoutView as the display item client. 824 // Frame scroll corner is painted using LayoutView as the display item client.
825 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 825 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
826 (GetFrameView()->HorizontalScrollbar() || 826 (GetFrameView()->HorizontalScrollbar() ||
827 GetFrameView()->VerticalScrollbar())) 827 GetFrameView()->VerticalScrollbar()))
828 return false; 828 return false;
829 829
830 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 830 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
831 } 831 }
832 832
833 } // namespace blink 833 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698