third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp - Issue 2872423002: Tweak PaintInvalidationReasons

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp

Issue 2872423002: Tweak PaintInvalidationReasons (Closed)

Patch Set: Rebaseline-cl Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp ('k') | third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp

index 4d69e7095d8729c12072ff2b3f5c765e5159c522..0d39195ce3ee762eaa1af23344e964c882ee27cb 100644

--- a/third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp

+++ b/third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp

@@ -45,7 +45,7 @@ TEST_F(ObjectPaintInvalidatorTest,

GetDocument().View()->SetTracksPaintInvalidations(true);

ObjectPaintInvalidator(*GetLayoutObjectByElementId("container"))

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

std::unique_ptr<JSONArray> invalidations =

GetDocument().View()->TrackedObjectPaintInvalidationsAsJSON();

GetDocument().View()->SetTracksPaintInvalidations(false);

@@ -103,7 +103,7 @@ TEST_F(ObjectPaintInvalidatorTest, TraverseFloatUnderCompositedInline) {

EXPECT_FALSE(composited_container_layer->NeedsRepaint());

ObjectPaintInvalidator(*target)

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

EXPECT_TRUE(containing_block_layer->NeedsRepaint());

EXPECT_TRUE(composited_container_layer->NeedsRepaint());

EXPECT_FALSE(span_layer->NeedsRepaint());

@@ -115,7 +115,7 @@ TEST_F(ObjectPaintInvalidatorTest, TraverseFloatUnderCompositedInline) {

EXPECT_FALSE(composited_container_layer->NeedsRepaint());

ObjectPaintInvalidator(*span)

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

EXPECT_TRUE(containing_block_layer->NeedsRepaint());

EXPECT_TRUE(composited_container_layer->NeedsRepaint());

EXPECT_TRUE(span_layer->NeedsRepaint());

@@ -128,7 +128,7 @@ TEST_F(ObjectPaintInvalidatorTest, TraverseFloatUnderCompositedInline) {

EXPECT_FALSE(composited_container_layer->NeedsRepaint());

ObjectPaintInvalidator(*composited_container)

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

EXPECT_TRUE(containing_block_layer->NeedsRepaint());

EXPECT_TRUE(composited_container_layer->NeedsRepaint());

EXPECT_FALSE(span_layer->NeedsRepaint());

@@ -195,7 +195,7 @@ TEST_F(ObjectPaintInvalidatorTest,

EXPECT_FALSE(composited_container_layer->NeedsRepaint());

ObjectPaintInvalidator(*composited_container)

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

EXPECT_TRUE(containing_block_layer->NeedsRepaint());

EXPECT_TRUE(composited_container_layer->NeedsRepaint());

EXPECT_FALSE(span_layer->NeedsRepaint());

@@ -243,7 +243,7 @@ TEST_F(ObjectPaintInvalidatorTest, TraverseStackedFloatUnderCompositedInline) {

EXPECT_FALSE(span_layer->NeedsRepaint());

ObjectPaintInvalidator(*span)

.InvalidateDisplayItemClientsIncludingNonCompositingDescendants(

- kPaintInvalidationSubtree);

+ PaintInvalidationReason::kSubtree);

EXPECT_TRUE(span_layer->NeedsRepaint());

std::unique_ptr<JSONArray> invalidations =