[DevTools] Support multiple sessions in content/ domain handlers

[DevTools] Support multiple sessions in content/ domain handlers

We now have a set of sessions (which has at most one element for now)
and retrieve multiple domain handlers at instrumentation points.

BUG=590878
Review-Url: https://codereview.chromium.org/2863623003
Cr-Commit-Position: refs/heads/master@{#469780}
Committed: https://chromium.googlesource.com/chromium/src/+/9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39

[dgozman, 2017-05-04 21:51:02]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 21:51:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:48:31]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-05 01:43:41]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2017-05-05 01:43:42]

Could you please take a look?

[caseq, 2017-05-05 18:27:24]

lgtm

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:410: for (auto*
page : protocol::PageHandler::ForAgentHost(agent_host)) {
page is somewhat unfortunate there. page_handler or at least just handler?

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:936: if
(frame_trace_recorder_ && did_initiate_recording) {
Let's bail out before the loop above if (!frame_trace_recorder_)

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:1122: if
(frame_trace_recorder_ && did_initiate_recording) {
as above.

https://codereview.chromium.org/2863623003/diff/1/content/browser/ssl/ssl_man...
File content/browser/ssl/ssl_manager.cc (right):

https://codereview.chromium.org/2863623003/diff/1/content/browser/ssl/ssl_man...
content/browser/ssl/ssl_manager.cc:387: for (auto* handler :
protocol::SecurityHandler::ForAgentHost(agent_host)) {
Let's pick a different name so as not to shadow function parameter.

[dgozman, 2017-05-05 20:29:42]

Thank you for review!

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
File content/browser/devtools/render_frame_devtools_agent_host.cc (right):

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:410: for (auto*
page : protocol::PageHandler::ForAgentHost(agent_host)) {
On 2017/05/05 18:27:24, caseq wrote:
> page is somewhat unfortunate there. page_handler or at least just handler?

Done.

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:936: if
(frame_trace_recorder_ && did_initiate_recording) {
On 2017/05/05 18:27:24, caseq wrote:
> Let's bail out before the loop above if (!frame_trace_recorder_)

Done.

https://codereview.chromium.org/2863623003/diff/1/content/browser/devtools/re...
content/browser/devtools/render_frame_devtools_agent_host.cc:1122: if
(frame_trace_recorder_ && did_initiate_recording) {
On 2017/05/05 18:27:24, caseq wrote:
> as above.

Done.

https://codereview.chromium.org/2863623003/diff/1/content/browser/ssl/ssl_man...
File content/browser/ssl/ssl_manager.cc (right):

https://codereview.chromium.org/2863623003/diff/1/content/browser/ssl/ssl_man...
content/browser/ssl/ssl_manager.cc:387: for (auto* handler :
protocol::SecurityHandler::ForAgentHost(agent_host)) {
On 2017/05/05 18:27:24, caseq wrote:
> Let's pick a different name so as not to shadow function parameter.

Done.

[dgozman, 2017-05-05 20:29:49]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 20:30:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:18:02]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-05 22:25:21]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-05-05 22:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2863623003/#ps20001
(title: "addressed review comments")

[commit-bot: I haz the power, 2017-05-05 22:26:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:35:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494023121859650,
"parent_rev": "ea259a34782be0b2cc32d3ced99c845d53d838e2", "commit_rev":
"9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39"}

[commit-bot: I haz the power, 2017-05-05 22:36:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494023121859650,
"parent_rev": "ea259a34782be0b2cc32d3ced99c845d53d838e2", "commit_rev":
"9bca3ccdd3cc9c9ad76186bb5339ca7a1c8a5e39"}

[commit-bot: I haz the power, 2017-05-05 22:36:42]

Description was changed from

==========
[DevTools] Support multiple sessions in content/ domain handlers

We now have a set of sessions (which has at most one element for now)
and retrieve multiple domain handlers at instrumentation points.

BUG=590878
==========

to

==========
[DevTools] Support multiple sessions in content/ domain handlers

We now have a set of sessions (which has at most one element for now)
and retrieve multiple domain handlers at instrumentation points.

BUG=590878

Review-Url: https://codereview.chromium.org/2863623003
Cr-Commit-Position: refs/heads/master@{#469780}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bca3ccdd3cc9c9ad76186bb5339...
==========

[commit-bot: I haz the power, 2017-05-05 22:36:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bca3ccdd3cc9c9ad76186bb5339...