Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: content/browser/devtools/service_worker_devtools_agent_host.cc

Issue 2863623003: [DevTools] Support multiple sessions in content/ domain handlers (Closed)
Patch Set: addressed review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/service_worker_devtools_agent_host.cc b/content/browser/devtools/service_worker_devtools_agent_host.cc
index 50cd14136a709c8fd1dc8aeca4fdbd65ba0196e0..5b8aef572128f482fc644cddb4b55e265bb23798 100644
--- a/content/browser/devtools/service_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/service_worker_devtools_agent_host.cc
@@ -119,12 +119,9 @@ void ServiceWorkerDevToolsAgentHost::WorkerVersionDoomed() {
void ServiceWorkerDevToolsAgentHost::NavigationPreloadRequestSent(
const std::string& request_id,
const ResourceRequest& request) {
- if (!session())
- return;
- if (protocol::NetworkHandler* network_handler =
- protocol::NetworkHandler::FromSession(session())) {
- network_handler->NavigationPreloadRequestSent(worker_id().first, request_id,
- request);
+ for (auto* network : protocol::NetworkHandler::ForAgentHost(this)) {
+ network->NavigationPreloadRequestSent(worker_id().first, request_id,
+ request);
}
}
@@ -132,24 +129,17 @@ void ServiceWorkerDevToolsAgentHost::NavigationPreloadResponseReceived(
const std::string& request_id,
const GURL& url,
const ResourceResponseHead& head) {
- if (!session())
- return;
- if (protocol::NetworkHandler* network_handler =
- protocol::NetworkHandler::FromSession(session())) {
- network_handler->NavigationPreloadResponseReceived(worker_id().first,
- request_id, url, head);
+ for (auto* network : protocol::NetworkHandler::ForAgentHost(this)) {
+ network->NavigationPreloadResponseReceived(worker_id().first, request_id,
+ url, head);
}
}
void ServiceWorkerDevToolsAgentHost::NavigationPreloadCompleted(
const std::string& request_id,
const ResourceRequestCompletionStatus& completion_status) {
- if (!session())
- return;
- if (protocol::NetworkHandler* network_handler =
- protocol::NetworkHandler::FromSession(session())) {
- network_handler->NavigationPreloadCompleted(request_id, completion_status);
- }
+ for (auto* network : protocol::NetworkHandler::ForAgentHost(this))
+ network->NavigationPreloadCompleted(request_id, completion_status);
}
int64_t ServiceWorkerDevToolsAgentHost::service_worker_version_id() const {
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/browser/devtools/worker_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698