content/browser/devtools/protocol/page_handler.h - Issue 2863623003: [DevTools] Support multiple sessions in content/ domain handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2863623003: [DevTools] Support multiple sessions in content/ domain handlers (Closed)

Patch Set: addressed review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.h

diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h

index faace0adfaf25306aba30490bb643e2128e4f982..52f43b53c71f6c5b1bf856764bc028978a239820 100644

--- a/content/browser/devtools/protocol/page_handler.h

+++ b/content/browser/devtools/protocol/page_handler.h

@@ -30,7 +30,7 @@ class Image;

namespace content {

-class DevToolsSession;

+class DevToolsAgentHostImpl;

class NavigationHandle;

class PageNavigationThrottle;

class RenderFrameHostImpl;

@@ -45,7 +45,7 @@ class PageHandler : public DevToolsDomainHandler,

PageHandler();

~PageHandler() override;

- static PageHandler* FromSession(DevToolsSession* session);

+ static std::vector<PageHandler*> ForAgentHost(DevToolsAgentHostImpl* host);

void Wire(UberDispatcher* dispatcher) override;

void SetRenderFrameHost(RenderFrameHostImpl* host) override;