content/browser/devtools/worker_devtools_agent_host.cc - Issue 2863623003: [DevTools] Support multiple sessions in content/ domain handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/worker_devtools_agent_host.cc

Issue 2863623003: [DevTools] Support multiple sessions in content/ domain handlers (Closed)

Patch Set: addressed review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/worker_devtools_agent_host.cc

diff --git a/content/browser/devtools/worker_devtools_agent_host.cc b/content/browser/devtools/worker_devtools_agent_host.cc

index a44eac333ea59e30d4d68b2cf1b6f035b849223a..c545a57113eccb58241b454df2a49e822d498120 100644

--- a/content/browser/devtools/worker_devtools_agent_host.cc

+++ b/content/browser/devtools/worker_devtools_agent_host.cc

@@ -123,7 +123,8 @@ void WorkerDevToolsAgentHost::WorkerDestroyed() {

DCHECK_NE(WORKER_TERMINATED, state_);

if (state_ == WORKER_INSPECTED) {

DCHECK(IsAttached());

- protocol::InspectorHandler::FromSession(session())->TargetCrashed();

+ for (auto* inspector : protocol::InspectorHandler::ForAgentHost(this))

+ inspector->TargetCrashed();

DetachFromWorker();

}

state_ = WORKER_TERMINATED;