Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2864103002: [DevTools] Support multiple DevToolsMessageChunkProcessor instances (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support multiple DevToolsMessageChunkProcessor instances Both in WorkerDevToolsAgentHost and RenderFrameDevToolsAgentHost. We now have one per session, a step towards multiclient. BUG=590878

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -71 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/devtools/devtools_session.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_session.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 8 chunks +88 lines, -49 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 5 chunks +18 lines, -7 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2874613003 Patch 1

Messages

Total messages: 8 (8 generated)
dgozman
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-06 00:11:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864103002/1
3 years, 7 months ago (2017-05-06 00:12:09 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-06 01:03:30 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/437505)
3 years, 7 months ago (2017-05-06 01:03:31 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-10 19:22:20 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864103002/20001
3 years, 7 months ago (2017-05-10 19:23:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-10 19:36:02 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:36:03 UTC) #8 
Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED, build has not started
yet; builder either lacks capacity or does not exist (misspelled?))

Powered by Google App Engine
This is Rietveld 408576698