[DevTools] Support multiple sessions in content/ domain handlers

content/browser/ssl/ssl_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/ssl/ssl_manager.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 365 matching lines @@
   const net::SSLInfo& ssl_info = handler->ssl_info();
   const GURL& request_url = handler->request_url();
   ResourceType resource_type = handler->resource_type();
 
   base::Callback<void(bool, content::CertificateRequestResultType)> callback =
       base::Bind(&OnAllowCertificate, base::Owned(handler.release()),
                  ssl_host_state_delegate_);
 
   DevToolsAgentHostImpl* agent_host = static_cast<DevToolsAgentHostImpl*>(
       DevToolsAgentHost::GetOrCreateFor(web_contents).get());
-  protocol::SecurityHandler* security_handler =
-      protocol::SecurityHandler::FromAgentHost(agent_host);
-  if (!security_handler ||
-      !security_handler->NotifyCertificateError(
-          cert_error, request_url,
-          base::Bind(&OnAllowCertificateWithRecordDecision, false, callback))) {
-    GetContentClient()->browser()->AllowCertificateError(
-        web_contents, cert_error, ssl_info, request_url, resource_type,
-        overridable, strict_enforcement, expired_previous_decision,
-        base::Bind(&OnAllowCertificateWithRecordDecision, true, callback));
+  if (agent_host) {
+    for (auto* handler : protocol::SecurityHandler::ForAgentHost(agent_host)) {

[caseq, 2017/05/05 18:27:24]

Let's pick a different name so as not to shadow function parameter.

[dgozman, 2017/05/05 20:29:42]

Done.

+      if (handler->NotifyCertificateError(
+              cert_error, request_url,
+              base::Bind(&OnAllowCertificateWithRecordDecision, false,
+                         callback))) {
+        return;
+      }
+    }
   }
+
+  GetContentClient()->browser()->AllowCertificateError(
+      web_contents, cert_error, ssl_info, request_url, resource_type,
+      overridable, strict_enforcement, expired_previous_decision,
+      base::Bind(&OnAllowCertificateWithRecordDecision, true, callback));
 }
 
 void SSLManager::UpdateEntry(NavigationEntryImpl* entry,
                              int add_content_status_flags,
                              int remove_content_status_flags) {
   // We don't always have a navigation entry to update, for example in the
   // case of the Web Inspector.
   if (!entry)
     return;
 
@@ skipping 47 matching lines @@
   SSLManagerSet* managers =
       static_cast<SSLManagerSet*>(context->GetUserData(kSSLManagerKeyName));
 
   for (std::set<SSLManager*>::iterator i = managers->get().begin();
        i != managers->get().end(); ++i) {
     (*i)->UpdateEntry((*i)->controller()->GetLastCommittedEntry(), 0, 0);
   }
 }
 
 }  // namespace content