[CRD iOS] Inject mouse events to the host

[CRD iOS] Inject mouse events to the host

This CL adds functionality to inject these mouse events:
* One-finger tap -> left click
* Two-finger tap -> right click
* Long-press -> Dragging

in touch input mode.

This CL also factors out an InputStrategy class from GestureInterpreter so that
later we can easily introduce the trackpad input mode.

BUG=718704
Review-Url: https://codereview.chromium.org/2862893003
Cr-Commit-Position: refs/heads/master@{#470171}
Committed: https://chromium.googlesource.com/chromium/src/+/d980e96a774c7e8d82039e5ef371b6ac0cb33b5d

[Yuwei, 2017-05-05 05:28:02]

yuweih@chromium.org changed reviewers:
+ nicholss@chromium.org

[Yuwei, 2017-05-05 05:28:03]

PTAL thanks!

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
File remoting/client/ios/session/remoting_client.mm (right):

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
remoting/client/ios/session/remoting_client.mm:118: _session.reset(new
remoting::ChromotingSession(
It looks like connectToHost is called on the UI thread so I just moved it out of
the closure. Otherwise I would get trouble initializing the _gestureInterpreter.

I can revert this change if there is a particular reason to do the PostTask.

[Yuwei, 2017-05-05 05:35:10]

Description was changed from

==========
[CRD iOS] Sending click and right click to the host
==========

to

==========
[CRD iOS] Inject mouse events to the host

This CL adds functionality to inject these mouse events:
* One-finger tap -> left click
* Two-finger tap -> right click
* Long-press -> Dragging

in touch input mode.

This CL also factors out an InputStrategy class from GestureInterpreter so that
later we can easily introduce the trackpad input mode.

BUG=718704
==========

[nicholss, 2017-05-08 15:34:18]

LGTM, I have a comment on refactoring a function name to be more readable but it
looks good, thanks for the work!

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/deskto...
File remoting/client/desktop_viewport.h (right):

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/deskto...
remoting/client/desktop_viewport.h:52: void MoveViewportCenter(float dx, float
dy);

I don't think "center" matters here, this method sounds more like
"translateViewport" with dx, dy. all pixels will be translated by the same
amount.

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
File remoting/client/ios/session/remoting_client.mm (right):

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
remoting/client/ios/session/remoting_client.mm:118: _session.reset(new
remoting::ChromotingSession(
On 2017/05/05 05:28:02, Yuwei wrote:
> It looks like connectToHost is called on the UI thread so I just moved it out
of
> the closure. Otherwise I would get trouble initializing the
_gestureInterpreter.
> 
> I can revert this change if there is a particular reason to do the PostTask.

I think it is fine unless ->Connect is blocking

[Yuwei, 2017-05-08 20:45:26]

Thanks! Checking-in

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/deskto...
File remoting/client/desktop_viewport.h (right):

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/deskto...
remoting/client/desktop_viewport.h:52: void MoveViewportCenter(float dx, float
dy);
On 2017/05/08 15:34:18, nicholss wrote:
> 
> I don't think "center" matters here, this method sounds more like
> "translateViewport" with dx, dy. all pixels will be translated by the same
> amount.

Done. Also renamed MoveViewportcenterWithoutUpdate

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
File remoting/client/ios/session/remoting_client.mm (right):

https://codereview.chromium.org/2862893003/diff/180001/remoting/client/ios/se...
remoting/client/ios/session/remoting_client.mm:118: _session.reset(new
remoting::ChromotingSession(
On 2017/05/08 15:34:18, nicholss wrote:
> On 2017/05/05 05:28:02, Yuwei wrote:
> > It looks like connectToHost is called on the UI thread so I just moved it
out
> of
> > the closure. Otherwise I would get trouble initializing the
> _gestureInterpreter.
> > 
> > I can revert this change if there is a particular reason to do the PostTask.
> 
> I think it is fine unless ->Connect is blocking

ChromotingSession will just post a task to connect on the network thread so I
think it's fine.

[Yuwei, 2017-05-08 20:45:30]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2017-05-08 20:45:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
nicholss@chromium.org
Link to the patchset: https://codereview.chromium.org/2862893003/#ps200001
(title: "Resolve Feedback")

[commit-bot: I haz the power, 2017-05-08 20:46:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2017-05-09 00:01:33]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-05-09 00:01:47]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-09 00:07:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuwei, 2017-05-09 01:16:09]

The CQ bit was unchecked by yuweih@chromium.org

[Yuwei, 2017-05-09 01:16:42]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:19:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:53:09]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494292602003160,
"parent_rev": "366a58f33368dabc4ed3695d9b65ec8faf855b8f", "commit_rev":
"d980e96a774c7e8d82039e5ef371b6ac0cb33b5d"}

[commit-bot: I haz the power, 2017-05-09 03:53:26]

Description was changed from

==========
[CRD iOS] Inject mouse events to the host

This CL adds functionality to inject these mouse events:
* One-finger tap -> left click
* Two-finger tap -> right click
* Long-press -> Dragging

in touch input mode.

This CL also factors out an InputStrategy class from GestureInterpreter so that
later we can easily introduce the trackpad input mode.

BUG=718704
==========

to

==========
[CRD iOS] Inject mouse events to the host

This CL adds functionality to inject these mouse events:
* One-finger tap -> left click
* Two-finger tap -> right click
* Long-press -> Dragging

in touch input mode.

This CL also factors out an InputStrategy class from GestureInterpreter so that
later we can easily introduce the trackpad input mode.

BUG=718704

Review-Url: https://codereview.chromium.org/2862893003
Cr-Commit-Position: refs/heads/master@{#470171}
Committed:
https://chromium.googlesource.com/chromium/src/+/d980e96a774c7e8d82039e5ef371...
==========

[commit-bot: I haz the power, 2017-05-09 03:53:27]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d980e96a774c7e8d82039e5ef371...