[CRD iOS] Inject mouse events to the host

remoting/client/ios/session/remoting_client.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/client/ios/session/remoting_client.h"
 
@@ skipping 48 matching lines @@
            selector:@selector(hostSessionPinProvided:)
                name:kHostSessionPinProvided
              object:nil];
   }
   return self;
 }
 
 - (void)connectToHost:(HostInfo*)hostInfo
              username:(NSString*)username
           accessToken:(NSString*)accessToken {
+  DCHECK(_runtime->ui_task_runner()->BelongsToCurrentThread());
   DCHECK(hostInfo);
   DCHECK(hostInfo.jabberId);
   DCHECK(hostInfo.hostId);
   DCHECK(hostInfo.publicKey);
 
   _sessionDetails.hostInfo = hostInfo;
 
   remoting::ConnectToHostInfo info;
   info.username = base::SysNSStringToUTF8(username);
   info.auth_token = base::SysNSStringToUTF8(accessToken);
@@ skipping 27 matching lines @@
                         userInfo:[NSDictionary
                                      dictionaryWithObject:_sessionDetails
                                                    forKey:kSessionDetails]];
       });
 
   // TODO(nicholss): Add audio support to iOS.
   base::WeakPtr<remoting::protocol::AudioStub> audioPlayer = nullptr;
 
   _displayHandler = [[GlDisplayHandler alloc] init];
   _displayHandler.delegate = self;
+
+  _session.reset(new remoting::ChromotingSession(

[Yuwei, 2017/05/05 05:28:02]

It looks like connectToHost is called on the UI thread so I just moved it out of
the closure. Otherwise I would get trouble initializing the _gestureInterpreter.

I can revert this change if there is a particular reason to do the PostTask.

[nicholss, 2017/05/08 15:34:18]

I think it is fine unless ->Connect is blocking

[Yuwei, 2017/05/08 20:45:26]

ChromotingSession will just post a task to connect on the network thread so I
think it's fine.

+      _sessonDelegate->GetWeakPtr(), [_displayHandler CreateCursorShapeStub],
+      [_displayHandler CreateVideoRenderer], audioPlayer, info,
+      client_auth_config));
+  _session->Connect();
+
   __weak GlDisplayHandler* weakDisplayHandler = _displayHandler;
   _gestureInterpreter.reset(new remoting::GestureInterpreter(
       base::BindBlockArc(^(const remoting::ViewMatrix& matrix) {
         [weakDisplayHandler onPixelTransformationChanged:matrix];
-      })));
-
-  _runtime->ui_task_runner()->PostTask(
-      FROM_HERE, base::BindBlockArc(^{
-        _session.reset(new remoting::ChromotingSession(
-            _sessonDelegate->GetWeakPtr(),
-            [_displayHandler CreateCursorShapeStub],
-            [_displayHandler CreateVideoRenderer], audioPlayer, info,
-            client_auth_config));
-        _session->Connect();
-      }));
+      }),
+      _session.get()));
 }
 
 #pragma mark - Eventing
 
 - (void)hostSessionPinProvided:(NSNotification*)notification {
   NSString* pin = [[notification userInfo] objectForKey:kHostSessionPin];
   if (_secretFetchedCallback) {
     _runtime->network_task_runner()->PostTask(
         FROM_HERE, base::BindBlockArc(^{
           _secretFetchedCallback.Run(base::SysNSStringToUTF8(pin));
@@ skipping 82 matching lines @@
 
 #pragma mark - GlDisplayHandlerDelegate
 
 - (void)canvasSizeChanged:(CGSize)size {
   if (_gestureInterpreter) {
     _gestureInterpreter->OnDesktopSizeChanged(size.width, size.height);
   }
 }
 
 @end