Remove GridLayout::SetInsets in favor of an empty border on the host.

Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG=716222
Review-Url: https://codereview.chromium.org/2859193004
Cr-Commit-Position: refs/heads/master@{#470675}
Committed: https://chromium.googlesource.com/chromium/src/+/a42af916f8540c65e68d780e37bc07a8230eb5ba

[Bret, 2017-05-05 00:42:59]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 00:43:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-05-05 01:24:38]

Description was changed from

==========
Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG=716222
==========

to

==========
Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG=716222
==========

[Bret, 2017-05-05 01:24:38]

bsep@chromium.org changed reviewers:
+ sky@chromium.org

[Bret, 2017-05-05 01:25:58]

This is the GridLayout changes from the other patch split out, with the changes
you suggested.

[sky, 2017-05-05 14:36:39]

Did you verify none of the views you are changing were using borders already?

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
(right):

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc:115:
constexpr int kInset = 40;
optional: kInset is rather generic, maybe kOtherInset.

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc:117:
views::GridLayout* grid_layout = views::GridLayout::CreatePanel(this);
As the next line sets the border, how about not using CreatePanel?

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:240:
constexpr int kFooterVerticalInset = 16;
optional: as these values are the same combine and rename to kInset.

https://codereview.chromium.org/2859193004/diff/20001/ui/views/layout/grid_la...
File ui/views/layout/grid_layout.h (right):

https://codereview.chromium.org/2859193004/diff/20001/ui/views/layout/grid_la...
ui/views/layout/grid_layout.h:14: #include "ui/gfx/geometry/insets.h"
If you can, remove this include.

[Bret, 2017-05-05 21:19:37]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 21:20:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 21:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 21:26:36]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Bret, 2017-05-06 00:36:43]

> Did you verify none of the views you are changing were using borders already?

I doubled-checked and I'd missed some views using CreatePaymentRequestRowBorder.
But now that's fixed and I'm not overwriting the border anywhere.

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc
(right):

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc:115:
constexpr int kInset = 40;
On 2017/05/05 14:36:39, sky wrote:
> optional: kInset is rather generic, maybe kOtherInset.

Done.

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc:117:
views::GridLayout* grid_layout = views::GridLayout::CreatePanel(this);
On 2017/05/05 14:36:39, sky wrote:
> As the next line sets the border, how about not using CreatePanel?

Done. Though like in the previous patch, my plan is to replace CreatePanel with
a method that sets the host view's layout manager.

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2859193004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:240:
constexpr int kFooterVerticalInset = 16;
On 2017/05/05 14:36:39, sky wrote:
> optional: as these values are the same combine and rename to kInset.

Done.

https://codereview.chromium.org/2859193004/diff/20001/ui/views/layout/grid_la...
File ui/views/layout/grid_layout.h (right):

https://codereview.chromium.org/2859193004/diff/20001/ui/views/layout/grid_la...
ui/views/layout/grid_layout.h:14: #include "ui/gfx/geometry/insets.h"
On 2017/05/05 14:36:39, sky wrote:
> If you can, remove this include.

Done.

[Bret, 2017-05-06 00:36:50]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 00:37:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 00:57:37]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Bret, 2017-05-06 01:23:28]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 01:24:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 01:38:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 01:38:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-05-06 19:51:33]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 19:51:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 20:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 20:07:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-05-07 02:15:04]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-07 02:15:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-05-07 02:17:18]

On 2017/05/06 00:36:43, Bret Sepulveda wrote:
> > Did you verify none of the views you are changing were using borders
already?
> 
> I doubled-checked and I'd missed some views using
CreatePaymentRequestRowBorder.
> But now that's fixed and I'm not overwriting the border anywhere.

I also found that MessageCenterView was setting a border on
MessageCenterButtonBar so I folded it into the actual GridLayout rows/columns.
And then I triple-checked that that was the actual last one.

[commit-bot: I haz the power, 2017-05-07 02:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-07 02:28:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-05-07 22:26:14]

Assuming the change to 51 is expected, LGTM

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/payments/payment_request_row_view.h (right):

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/payment_request_row_view.h:21: const
gfx::Insets& insets);
Document what insets is used for.

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/payment_request_views_util.h:121: const
gfx::Insets& insets = gfx::Insets());
Document insets.

https://codereview.chromium.org/2859193004/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view_unittest.cc (right):

https://codereview.chromium.org/2859193004/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view_unittest.cc:854: const int
kLockedMessageCenterViewHeight = 51;
How come you had to change this value (and the value on line 931 as well).

[Bret, 2017-05-09 20:46:33]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 20:47:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 20:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 20:54:37]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Bret, 2017-05-09 21:46:19]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:48:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-05-09 22:03:09]

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/payments/payment_request_row_view.h (right):

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/payment_request_row_view.h:21: const
gfx::Insets& insets);
On 2017/05/07 22:26:14, sky wrote:
> Document what insets is used for.

Done.

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/payments/payment_request_views_util.h (right):

https://codereview.chromium.org/2859193004/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/payments/payment_request_views_util.h:121: const
gfx::Insets& insets = gfx::Insets());
On 2017/05/07 22:26:14, sky wrote:
> Document insets.

Done. Also removed the default insets because I noticed they weren't used.

https://codereview.chromium.org/2859193004/diff/120001/ui/message_center/view...
File ui/message_center/views/message_center_view_unittest.cc (right):

https://codereview.chromium.org/2859193004/diff/120001/ui/message_center/view...
ui/message_center/views/message_center_view_unittest.cc:854: const int
kLockedMessageCenterViewHeight = 51;
On 2017/05/07 22:26:14, sky wrote:
> How come you had to change this value (and the value on line 931 as well).

There's a 1-dip-high border added in MessageCenterView::Layout that was
previously being ignored by GridLayout. So now that it's being accounted for,
the height has increased by 1 dip.

[commit-bot: I haz the power, 2017-05-09 22:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 22:05:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2017-05-09 23:08:56]

SLGTM

[Bret, 2017-05-09 23:43:50]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-05-09 23:43:51]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2859193004/#ps180001
(title: "missed a merge problem")

[commit-bot: I haz the power, 2017-05-09 23:44:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:47:47]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[Bret, 2017-05-10 18:51:38]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-05-10 18:53:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:49:28]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1494442298377010,
"parent_rev": "0f0b3b210e12735f095829d1ee1277fe60de5d5b", "commit_rev":
"a42af916f8540c65e68d780e37bc07a8230eb5ba"}

[commit-bot: I haz the power, 2017-05-10 19:49:38]

Description was changed from

==========
Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG=716222
==========

to

==========
Remove GridLayout::SetInsets in favor of an empty border on the host.

GridLayout::SetInsets is a way of introducing whitespace around the
edges of a view. However we normally accomplish that by setting an empty
border on the view instead. This patch changes all usages of the former
to the latter, and then deletes the method.

BUG=716222

Review-Url: https://codereview.chromium.org/2859193004
Cr-Commit-Position: refs/heads/master@{#470675}
Committed:
https://chromium.googlesource.com/chromium/src/+/a42af916f8540c65e68d780e37bc...
==========

[commit-bot: I haz the power, 2017-05-10 19:49:40]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/a42af916f8540c65e68d780e37bc...