Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: mash/catalog_viewer/catalog_viewer.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)
Patch Set: missed a merge problem Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mash/catalog_viewer/catalog_viewer.h" 5 #include "mash/catalog_viewer/catalog_viewer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "mojo/public/cpp/bindings/binding.h" 15 #include "mojo/public/cpp/bindings/binding.h"
16 #include "services/catalog/public/interfaces/catalog.mojom.h" 16 #include "services/catalog/public/interfaces/catalog.mojom.h"
17 #include "services/catalog/public/interfaces/constants.mojom.h" 17 #include "services/catalog/public/interfaces/constants.mojom.h"
18 #include "services/service_manager/public/cpp/connector.h" 18 #include "services/service_manager/public/cpp/connector.h"
19 #include "services/service_manager/public/cpp/service_context.h" 19 #include "services/service_manager/public/cpp/service_context.h"
20 #include "ui/base/models/table_model.h" 20 #include "ui/base/models/table_model.h"
21 #include "ui/base/resource/resource_bundle.h" 21 #include "ui/base/resource/resource_bundle.h"
22 #include "ui/resources/grit/ui_resources.h" 22 #include "ui/resources/grit/ui_resources.h"
23 #include "ui/views/background.h" 23 #include "ui/views/background.h"
24 #include "ui/views/border.h"
24 #include "ui/views/controls/label.h" 25 #include "ui/views/controls/label.h"
25 #include "ui/views/controls/table/table_view.h" 26 #include "ui/views/controls/table/table_view.h"
26 #include "ui/views/controls/table/table_view_observer.h" 27 #include "ui/views/controls/table/table_view_observer.h"
27 #include "ui/views/controls/textfield/textfield.h" 28 #include "ui/views/controls/textfield/textfield.h"
28 #include "ui/views/controls/textfield/textfield_controller.h" 29 #include "ui/views/controls/textfield/textfield_controller.h"
29 #include "ui/views/layout/grid_layout.h" 30 #include "ui/views/layout/grid_layout.h"
30 #include "ui/views/mus/aura_init.h" 31 #include "ui/views/mus/aura_init.h"
31 #include "ui/views/widget/widget.h" 32 #include "ui/views/widget/widget.h"
32 #include "ui/views/widget/widget_delegate.h" 33 #include "ui/views/widget/widget_delegate.h"
33 34
34 namespace mash { 35 namespace mash {
35 namespace catalog_viewer { 36 namespace catalog_viewer {
36 namespace { 37 namespace {
37 38
38 class CatalogViewerContents : public views::WidgetDelegateView, 39 class CatalogViewerContents : public views::WidgetDelegateView,
39 public ui::TableModel, 40 public ui::TableModel,
40 public views::TextfieldController { 41 public views::TextfieldController {
41 public: 42 public:
42 CatalogViewerContents(CatalogViewer* catalog_viewer, 43 CatalogViewerContents(CatalogViewer* catalog_viewer,
43 catalog::mojom::CatalogPtr catalog) 44 catalog::mojom::CatalogPtr catalog)
44 : catalog_viewer_(catalog_viewer), 45 : catalog_viewer_(catalog_viewer),
45 catalog_(std::move(catalog)), 46 catalog_(std::move(catalog)),
46 table_view_(nullptr), 47 table_view_(nullptr),
47 table_view_parent_(nullptr), 48 table_view_parent_(nullptr),
48 observer_(nullptr), 49 observer_(nullptr),
49 capability_(new views::Textfield) { 50 capability_(new views::Textfield) {
50 const int kPadding = 5; 51 constexpr int kPadding = 5;
52 SetBorder(views::CreateEmptyBorder(gfx::Insets(kPadding)));
51 set_background(views::Background::CreateStandardPanelBackground()); 53 set_background(views::Background::CreateStandardPanelBackground());
52 54
53 views::GridLayout* layout = new views::GridLayout(this); 55 views::GridLayout* layout = new views::GridLayout(this);
54 layout->SetInsets(kPadding, kPadding, kPadding, kPadding);
55 SetLayoutManager(layout); 56 SetLayoutManager(layout);
56 57
57 views::ColumnSet* columns = layout->AddColumnSet(0); 58 views::ColumnSet* columns = layout->AddColumnSet(0);
58 columns->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 0, 59 columns->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 0,
59 views::GridLayout::USE_PREF, 0, 0); 60 views::GridLayout::USE_PREF, 0, 0);
60 columns->AddPaddingColumn(0, kPadding); 61 columns->AddPaddingColumn(0, kPadding);
61 columns->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1, 62 columns->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
62 views::GridLayout::USE_PREF, 0, 0); 63 views::GridLayout::USE_PREF, 0, 0);
63 64
64 layout->StartRow(0, 0); 65 layout->StartRow(0, 0);
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 windows_.push_back(window); 251 windows_.push_back(window);
251 } 252 }
252 253
253 void CatalogViewer::Create(const service_manager::BindSourceInfo& source_info, 254 void CatalogViewer::Create(const service_manager::BindSourceInfo& source_info,
254 mojom::LaunchableRequest request) { 255 mojom::LaunchableRequest request) {
255 bindings_.AddBinding(this, std::move(request)); 256 bindings_.AddBinding(this, std::move(request));
256 } 257 }
257 258
258 } // namespace catalog_viewer 259 } // namespace catalog_viewer
259 } // namespace mash 260 } // namespace mash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698