chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)

Patch Set: missed a merge problem Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc ('k') | chrome/browser/ui/views/first_run_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index 7a3ffa6f68178a795ea628bc55b65c13d44b7879..2e83f92f8b42dd197b4a54275fb9b46d4a4b6fa7 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -456,8 +456,9 @@ views::GridLayout* ExtensionInstallDialogView::CreateLayout(

// title, but on the same y-axis, and the scroll view used to contain other

// content can have its scrollbar aligned with the right edge of the dialog.

views::GridLayout* layout = new views::GridLayout(container_);

- layout->SetInsets(0, horizontal_margin, bottom_margin, 0);

container_->SetLayoutManager(layout);

+ container_->SetBorder(

+ views::CreateEmptyBorder(0, horizontal_margin, bottom_margin, 0));

AddChildView(container_);

views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);