Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5558)

Unified Diff: chrome/browser/ui/views/payments/payment_request_item_list.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)
Patch Set: missed a merge problem Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_item_list.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_item_list.cc b/chrome/browser/ui/views/payments/payment_request_item_list.cc
index cef163242e9fdfa808184dc5bbd4a3782cd40a5f..0cef61ec6bc84ac48121b7c06491cd67c830604a 100644
--- a/chrome/browser/ui/views/payments/payment_request_item_list.cc
+++ b/chrome/browser/ui/views/payments/payment_request_item_list.cc
@@ -72,17 +72,17 @@ std::unique_ptr<views::View> PaymentRequestItemList::Item::CreateExtraView() {
std::unique_ptr<views::View> PaymentRequestItemList::Item::CreateItemView() {
std::unique_ptr<views::View> content = CreateContentView();
+ const gfx::Insets row_insets(
+ kPaymentRequestRowVerticalInsets, kPaymentRequestRowHorizontalInsets,
+ kPaymentRequestRowVerticalInsets,
+ kPaymentRequestRowHorizontalInsets + kPaymentRequestRowExtraRightInset);
std::unique_ptr<PaymentRequestRowView> row =
base::MakeUnique<PaymentRequestRowView>(this,
- /* clickable= */ IsEnabled());
+ /* clickable= */ IsEnabled(),
+ row_insets);
views::GridLayout* layout = new views::GridLayout(row.get());
row->SetLayoutManager(layout);
- layout->SetInsets(
- kPaymentRequestRowVerticalInsets, kPaymentRequestRowHorizontalInsets,
- kPaymentRequestRowVerticalInsets,
- kPaymentRequestRowHorizontalInsets + kPaymentRequestRowExtraRightInset);
-
// Add a column for the item's content view.
views::ColumnSet* columns = layout->AddColumnSet(0);
columns->AddColumn(views::GridLayout::FILL, views::GridLayout::LEADING, 1,

Powered by Google App Engine
This is Rietveld 408576698