Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: mash/catalog_viewer/catalog_viewer.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)
Patch Set: missed a merge problem Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mash/catalog_viewer/catalog_viewer.cc
diff --git a/mash/catalog_viewer/catalog_viewer.cc b/mash/catalog_viewer/catalog_viewer.cc
index a79a45c937231733cf3eb14affa5fce26b99f684..621a5412f875770029566e68301bced9d7c41152 100644
--- a/mash/catalog_viewer/catalog_viewer.cc
+++ b/mash/catalog_viewer/catalog_viewer.cc
@@ -21,6 +21,7 @@
#include "ui/base/resource/resource_bundle.h"
#include "ui/resources/grit/ui_resources.h"
#include "ui/views/background.h"
+#include "ui/views/border.h"
#include "ui/views/controls/label.h"
#include "ui/views/controls/table/table_view.h"
#include "ui/views/controls/table/table_view_observer.h"
@@ -47,11 +48,11 @@ class CatalogViewerContents : public views::WidgetDelegateView,
table_view_parent_(nullptr),
observer_(nullptr),
capability_(new views::Textfield) {
- const int kPadding = 5;
+ constexpr int kPadding = 5;
+ SetBorder(views::CreateEmptyBorder(gfx::Insets(kPadding)));
set_background(views::Background::CreateStandardPanelBackground());
views::GridLayout* layout = new views::GridLayout(this);
- layout->SetInsets(kPadding, kPadding, kPadding, kPadding);
SetLayoutManager(layout);
views::ColumnSet* columns = layout->AddColumnSet(0);

Powered by Google App Engine
This is Rietveld 408576698