chrome/browser/ui/views/first_run_bubble.cc - Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/first_run_bubble.cc

Issue 2859193004: Remove GridLayout::SetInsets in favor of an empty border on the host. (Closed)

Patch Set: missed a merge problem Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/first_run_bubble.cc

diff --git a/chrome/browser/ui/views/first_run_bubble.cc b/chrome/browser/ui/views/first_run_bubble.cc

index 684c9dc1b68f2a8ebac013252276bf8f1312ff55..70098c35ba2f039af558b2b659e70a4e69dfe24a 100644

--- a/chrome/browser/ui/views/first_run_bubble.cc

+++ b/chrome/browser/ui/views/first_run_bubble.cc

@@ -63,7 +63,8 @@ void FirstRunBubble::Init() {

l10n_util::GetStringUTF16(IDS_FR_BUBBLE_SUBTEXT), {original_font_list});

views::GridLayout* layout = views::GridLayout::CreatePanel(this);

- layout->SetInsets(kTopInset, kLeftInset, kBottomInset, kRightInset);

+ SetBorder(views::CreateEmptyBorder(kTopInset, kLeftInset, kBottomInset,

+ kRightInset));

ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();