telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag.

telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag.

context: https://codereview.chromium.org/2851453003/

BUG=

Review-Url: https://codereview.chromium.org/2855333002
Cr-Commit-Position: refs/heads/master@{#469445}
Committed: https://chromium.googlesource.com/chromium/src/+/51adbbad187d9fc07d295d681123b525b56aae36

[CalebRouleau, 2017-05-04 00:23:55]

Description was changed from

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

BUG=
==========

to

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

BUG=
==========

[CalebRouleau, 2017-05-04 00:23:55]

crouleau@chromium.org changed reviewers:
+ johnchen@chromium.org, nednguyen@google.com, timvolodine@chromium.org

[CalebRouleau, 2017-05-04 00:26:35]

PTAL

[CalebRouleau, 2017-05-04 00:26:59]

Description was changed from

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

BUG=
==========

to

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

context: https://codereview.chromium.org/2851453003/

BUG=
==========

[nednguyen, 2017-05-04 00:30:23]

https://codereview.chromium.org/2855333002/diff/20001/tools/perf/benchmarks/b...
File tools/perf/benchmarks/blink_perf.py (right):

https://codereview.chromium.org/2855333002/diff/20001/tools/perf/benchmarks/b...
tools/perf/benchmarks/blink_perf.py:154: # reference builds.
Can you document which one is the old one & at which Chromium revision can we
only use the new flag?

[CalebRouleau, 2017-05-04 17:57:53]

On 2017/05/04 00:30:23, nednguyen wrote:
>
https://codereview.chromium.org/2855333002/diff/20001/tools/perf/benchmarks/b...
> File tools/perf/benchmarks/blink_perf.py (right):
> 
>
https://codereview.chromium.org/2855333002/diff/20001/tools/perf/benchmarks/b...
> tools/perf/benchmarks/blink_perf.py:154: # reference builds.
> Can you document which one is the old one & at which Chromium revision can we
> only use the new flag?

Done. PTAL

[johnchen, 2017-05-04 17:58:18]

lgtm

[nednguyen, 2017-05-04 18:00:46]

lgtm

[CalebRouleau, 2017-05-04 18:03:36]

The CQ bit was checked by crouleau@chromium.org

[commit-bot: I haz the power, 2017-05-04 18:04:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:13:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493921016136840,
"parent_rev": "541c600149fe0cedcb48649763f137142c467f1f", "commit_rev":
"51adbbad187d9fc07d295d681123b525b56aae36"}

[commit-bot: I haz the power, 2017-05-04 20:13:48]

Description was changed from

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

context: https://codereview.chromium.org/2851453003/

BUG=
==========

to

==========
telemetry: support old builds that still use
disable-gesture-requirement-for-media-playback flag.

context: https://codereview.chromium.org/2851453003/

BUG=

Review-Url: https://codereview.chromium.org/2855333002
Cr-Commit-Position: refs/heads/master@{#469445}
Committed:
https://chromium.googlesource.com/chromium/src/+/51adbbad187d9fc07d295d681123...
==========

[commit-bot: I haz the power, 2017-05-04 20:13:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/51adbbad187d9fc07d295d681123...

[timvolodine, 2017-05-05 11:41:28]

timvolodine@chromium.org changed reviewers:
+ mlamouri@chromium.org

[timvolodine, 2017-05-05 11:41:29]

lgtm to me, though I think the original patch was by mlamouri@ (currently OOO)
so adding him to have a look when he comes back