tools/perf/benchmarks/blink_perf.py - Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag. (Closed)

Patch Set: More detailed comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/blink_perf.py

diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py

index 5f6786c374e3047bb5b469c77b3d6e4f239c435a..1808b8896ff8ff9896663cf889dad33f000058b0 100644

--- a/tools/perf/benchmarks/blink_perf.py

+++ b/tools/perf/benchmarks/blink_perf.py

@@ -145,7 +145,15 @@ class _BlinkPerfMeasurement(legacy_page_test.LegacyPageTest):

options.AppendExtraBrowserArgs([

'--js-flags=--expose_gc',

'--enable-experimental-web-platform-features',

+ # Note that both this flag:

'--ignore-autoplay-restrictions',

+ # and this flag:

+ '--disable-gesture-requirement-for-media-playback',

+ # should be used until every build from

+ # ToT to Stable switches over to one flag or another. This is to support

+ # reference builds.

+ # --disable-gesture-requirement-for-media-playback is the old one and

+ # can be removed after M60 goes to stable.

'--enable-experimental-canvas-features',

# TODO(qinmin): After fixing crbug.com/592017, remove this command line.

'--reduce-security-for-testing'

« no previous file with comments | « no previous file | tools/perf/benchmarks/media.py » ('j') | no next file with comments »