Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: tools/perf/benchmarks/media.py

Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag. (Closed)
Patch Set: More detailed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.page import legacy_page_test 8 from telemetry.page import legacy_page_test
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.value import list_of_scalar_values 10 from telemetry.value import list_of_scalar_values
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 return cls.IsSvelte(possible_browser) 149 return cls.IsSvelte(possible_browser)
150 150
151 @classmethod 151 @classmethod
152 def Name(cls): 152 def Name(cls):
153 return 'media.android.tough_video_cases_tbmv2' 153 return 'media.android.tough_video_cases_tbmv2'
154 154
155 def SetExtraBrowserOptions(self, options): 155 def SetExtraBrowserOptions(self, options):
156 # By default, Chrome on Android does not allow autoplay 156 # By default, Chrome on Android does not allow autoplay
157 # of media: it requires a user gesture event to start a video. 157 # of media: it requires a user gesture event to start a video.
158 # The following option works around that. 158 # The following option works around that.
159 options.AppendExtraBrowserArgs(['--ignore-autoplay-restrictions']) 159 # Note that both of these flags should be used until every build from
160 # ToT to Stable switches over to one flag or another. This is to support
161 # reference builds.
162 # --disable-gesture-requirement-for-media-playback is the old one and can be
163 # removed after M60 goes to stable.
164 options.AppendExtraBrowserArgs(
165 ['--ignore-autoplay-restrictions',
166 '--disable-gesture-requirement-for-media-playback'])
160 167
161 168
162 # This isn't running anywhere. See crbug/709161. 169 # This isn't running anywhere. See crbug/709161.
163 @benchmark.Enabled('chromeos') 170 @benchmark.Enabled('chromeos')
164 @benchmark.Owner(emails=['crouleau@chromium.org'], 171 @benchmark.Owner(emails=['crouleau@chromium.org'],
165 component='Internals>Media') 172 component='Internals>Media')
166 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark): 173 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark):
167 """Benchmark for media performance on ChromeOS using only is_4k test content. 174 """Benchmark for media performance on ChromeOS using only is_4k test content.
168 """ 175 """
169 test = media.Media 176 test = media.Media
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 218
212 @classmethod 219 @classmethod
213 def Name(cls): 220 def Name(cls):
214 return 'media.mse_cases' 221 return 'media.mse_cases'
215 222
216 def SetExtraBrowserOptions(self, options): 223 def SetExtraBrowserOptions(self, options):
217 # Needed to allow XHR requests to return stream objects. 224 # Needed to allow XHR requests to return stream objects.
218 options.AppendExtraBrowserArgs( 225 options.AppendExtraBrowserArgs(
219 ['--enable-experimental-web-platform-features', 226 ['--enable-experimental-web-platform-features',
220 '--ignore-autoplay-restrictions']) 227 '--ignore-autoplay-restrictions'])
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698