Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: tools/perf/benchmarks/blink_perf.py

Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag. (Closed)
Patch Set: fix blink_perf as well Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/media.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 9
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 self._blink_perf_js = f.read() 138 self._blink_perf_js = f.read()
139 139
140 def WillNavigateToPage(self, page, tab): 140 def WillNavigateToPage(self, page, tab):
141 del tab # unused 141 del tab # unused
142 page.script_to_evaluate_on_commit = self._blink_perf_js 142 page.script_to_evaluate_on_commit = self._blink_perf_js
143 143
144 def CustomizeBrowserOptions(self, options): 144 def CustomizeBrowserOptions(self, options):
145 options.AppendExtraBrowserArgs([ 145 options.AppendExtraBrowserArgs([
146 '--js-flags=--expose_gc', 146 '--js-flags=--expose_gc',
147 '--enable-experimental-web-platform-features', 147 '--enable-experimental-web-platform-features',
148 # Note that both this flag:
148 '--ignore-autoplay-restrictions', 149 '--ignore-autoplay-restrictions',
150 # and this flag:
151 '--disable-gesture-requirement-for-media-playback',
152 # should be used until every build from
153 # ToT to Stable switches over to one flag or another. This is to support
154 # reference builds.
nednguyen 2017/05/04 00:30:22 Can you document which one is the old one & at whi
149 '--enable-experimental-canvas-features', 155 '--enable-experimental-canvas-features',
150 # TODO(qinmin): After fixing crbug.com/592017, remove this command line. 156 # TODO(qinmin): After fixing crbug.com/592017, remove this command line.
151 '--reduce-security-for-testing' 157 '--reduce-security-for-testing'
152 ]) 158 ])
153 if 'content-shell' in options.browser_type: 159 if 'content-shell' in options.browser_type:
154 options.AppendExtraBrowserArgs('--expose-internals-for-testing') 160 options.AppendExtraBrowserArgs('--expose-internals-for-testing')
155 161
156 def _ContinueTestRunWithTracing(self, tab): 162 def _ContinueTestRunWithTracing(self, tab):
157 tracing_categories = tab.EvaluateJavaScript( 163 tracing_categories = tab.EvaluateJavaScript(
158 'testRunner.tracingCategories') 164 'testRunner.tracingCategories')
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 393
388 @benchmark.Owner(emails=['hayato@chromium.org']) 394 @benchmark.Owner(emails=['hayato@chromium.org'])
389 class BlinkPerfShadowDOM(_BlinkPerfBenchmark): 395 class BlinkPerfShadowDOM(_BlinkPerfBenchmark):
390 tag = 'shadow_dom' 396 tag = 'shadow_dom'
391 subdir = 'ShadowDOM' 397 subdir = 'ShadowDOM'
392 398
393 @classmethod 399 @classmethod
394 def ShouldDisable(cls, possible_browser): # http://crbug.com/702319 400 def ShouldDisable(cls, possible_browser): # http://crbug.com/702319
395 return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' 401 return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'
396 402
OLDNEW
« no previous file with comments | « no previous file | tools/perf/benchmarks/media.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698