tools/perf/benchmarks/media.py - Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/media.py

Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag. (Closed)

Patch Set: More detailed comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/media.py

diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py

index ddccefb6b1dc55ee1ed44ed7b47a4ae72f4cfc8d..e56c0796ff23d9dcdebaae1ac1efc39ae16eb67e 100644

--- a/tools/perf/benchmarks/media.py

+++ b/tools/perf/benchmarks/media.py

@@ -156,7 +156,14 @@ class MediaAndroidToughVideoCasesTBMv2(_MediaTBMv2Benchmark):

# By default, Chrome on Android does not allow autoplay

# of media: it requires a user gesture event to start a video.

# The following option works around that.

- options.AppendExtraBrowserArgs(['--ignore-autoplay-restrictions'])

+ # Note that both of these flags should be used until every build from

+ # ToT to Stable switches over to one flag or another. This is to support

+ # reference builds.

+ # --disable-gesture-requirement-for-media-playback is the old one and can be

+ # removed after M60 goes to stable.

+ options.AppendExtraBrowserArgs(

+ ['--ignore-autoplay-restrictions',

+ '--disable-gesture-requirement-for-media-playback'])

# This isn't running anywhere. See crbug/709161.

« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »