tools/perf/measurements/media.py - Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/media.py

Issue 2855333002: telemetry: support old builds that still use disable-gesture-requirement-for-media-playback flag. (Closed)

Patch Set: More detailed comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/media.py

diff --git a/tools/perf/measurements/media.py b/tools/perf/measurements/media.py

index 41f56a0ff914bf85bd76a337b338a52b41426f98..bed1efa09df43780855b71eb288d0ddcb0bfa51a 100644

--- a/tools/perf/measurements/media.py

+++ b/tools/perf/measurements/media.py

@@ -31,7 +31,14 @@ class Media(legacy_page_test.LegacyPageTest):

def CustomizeBrowserOptions(self, options):

# Needed to run media actions in JS on touch-based devices as on Android.

- options.AppendExtraBrowserArgs('--ignore-autoplay-restrictions')

+ # Note that both of these flags should be used until every build from

+ # ToT to Stable switches over to one flag or another. This is to support

+ # reference builds.

+ # --disable-gesture-requirement-for-media-playback is the old one and can be

+ # removed after M60 goes to stable.

+ options.AppendExtraBrowserArgs(

+ ['--ignore-autoplay-restrictions',

+ '--disable-gesture-requirement-for-media-playback'])

power.PowerMetric.CustomizeBrowserOptions(options)

def DidNavigateToPage(self, page, tab):

« no previous file with comments | « tools/perf/benchmarks/media.py ('k') | no next file » | no next file with comments »