Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2852953003: Use real colorspace for DirectComposition overlays.

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 6 months ago
Reviewers:
hubbe
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use real colorspace for DirectComposition overlays. Pickle up the gfx::ColorSpace and transmit it through the command buffer in ScheduleDCLayerCHROMIUM, then use it to pick the swapchain color space. BUG=654631 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : rebase #

Patch Set 4 : fix test #

Patch Set 5 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -133 lines) Patch
M cc/output/dc_layer_overlay.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/dc_layer_overlay.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 4 1 chunk +6 lines, -4 lines 1 comment Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 2 5 chunks +15 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 2 chunks +16 lines, -1 line 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 1 2 3 4 3 chunks +41 lines, -12 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 1 2 3 4 6 chunks +66 lines, -39 lines 0 comments Download
M ui/gfx/color_space.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gfx/color_space.cc View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits.cc View 1 chunk +2 lines, -37 lines 0 comments Download
M ui/gl/dc_renderer_layer_params.h View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M ui/gl/dc_renderer_layer_params.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (28 generated)
jbauman
3 years, 7 months ago (2017-05-18 23:26:57 UTC) #29
hubbe
3 years, 6 months ago (2017-06-20 18:23:28 UTC) #30
lgtm

https://codereview.chromium.org/2852953003/diff/80001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2852953003/diff/80001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:3276:
dc_layer_overlay.color_space.Serialize(&color_space_data);
This seems a little weird, shouldn't the gl layer do the pickling?

Powered by Google App Engine
This is Rietveld 408576698