Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark some non-spinvalidation methods deprecated, and update paint/README.md Also removed some delegate-to-superclass-only DeprecatedInvalidationPaint() because there is no more naming conflict with the new version. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2851453005 Cr-Commit-Position: refs/heads/master@{#468447} Committed: https://chromium.googlesource.com/chromium/src/+/6794758842707fe09980d5495fed326413767a5f

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : - #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -115 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 6 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/README.md View 1 2 3 8 chunks +44 lines, -45 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Xianzhu
3 years, 7 months ago (2017-05-01 16:02:24 UTC) #7
chrishtr
lgtm
3 years, 7 months ago (2017-05-01 18:00:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851453005/20001
3 years, 7 months ago (2017-05-01 18:01:00 UTC) #10
wkorman
lgtm https://codereview.chromium.org/2851453005/diff/20001/third_party/WebKit/Source/core/paint/README.md File third_party/WebKit/Source/core/paint/README.md (right): https://codereview.chromium.org/2851453005/diff/20001/third_party/WebKit/Source/core/paint/README.md#newcode257 third_party/WebKit/Source/core/paint/README.md:257: [`PaintInvalidator](PaintInvalidator.h) Missing closing `
3 years, 7 months ago (2017-05-01 18:03:29 UTC) #11
Xianzhu
https://codereview.chromium.org/2851453005/diff/20001/third_party/WebKit/Source/core/paint/README.md File third_party/WebKit/Source/core/paint/README.md (right): https://codereview.chromium.org/2851453005/diff/20001/third_party/WebKit/Source/core/paint/README.md#newcode257 third_party/WebKit/Source/core/paint/README.md:257: [`PaintInvalidator](PaintInvalidator.h) On 2017/05/01 18:03:29, wkorman wrote: > Missing closing ...
3 years, 7 months ago (2017-05-01 19:11:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851453005/60001
3 years, 7 months ago (2017-05-01 19:12:27 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:12:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6794758842707fe09980d5495fed...

Powered by Google App Engine
This is Rietveld 408576698