Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutPart.cpp

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Simon Hausmann <hausmann@kde.org> 3 * (C) 2000 Simon Hausmann <hausmann@kde.org>
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 // TODO(trchen): Remove this hack once we fixed all callers. 395 // TODO(trchen): Remove this hack once we fixed all callers.
396 FloatRect absolute_bounding_box = 396 FloatRect absolute_bounding_box =
397 LocalToAbsoluteQuad(FloatRect(ReplacedContentRect())).BoundingBox(); 397 LocalToAbsoluteQuad(FloatRect(ReplacedContentRect())).BoundingBox();
398 frame_rect.SetLocation(RoundedIntPoint(absolute_bounding_box.Location())); 398 frame_rect.SetLocation(RoundedIntPoint(absolute_bounding_box.Location()));
399 399
400 // Why is the protector needed? 400 // Why is the protector needed?
401 RefPtr<LayoutPart> protector(this); 401 RefPtr<LayoutPart> protector(this);
402 frame_or_plugin.SetFrameRect(frame_rect); 402 frame_or_plugin.SetFrameRect(frame_rect);
403 } 403 }
404 404
405 void LayoutPart::InvalidatePaintOfSubtreesIfNeeded( 405 void LayoutPart::DeprecatedInvalidatePaintOfSubtrees(
406 const PaintInvalidationState& paint_invalidation_state) { 406 const PaintInvalidationState& paint_invalidation_state) {
407 FrameView* frame_view = ChildFrameView(); 407 FrameView* frame_view = ChildFrameView();
408 if (frame_view && !IsThrottledFrameView()) { 408 if (frame_view && !IsThrottledFrameView()) {
409 // |childFrameView| is in another document, which could be 409 // |childFrameView| is in another document, which could be
410 // missing its LayoutView. TODO(jchaffraix): Ideally we should 410 // missing its LayoutView. TODO(jchaffraix): Ideally we should
411 // not need this code. 411 // not need this code.
412 if (LayoutView* child_layout_view = ToLayoutView( 412 if (LayoutView* child_layout_view = ToLayoutView(
413 LayoutAPIShim::LayoutObjectFrom(frame_view->GetLayoutViewItem()))) { 413 LayoutAPIShim::LayoutObjectFrom(frame_view->GetLayoutViewItem()))) {
414 PaintInvalidationState child_view_paint_invalidation_state( 414 PaintInvalidationState child_view_paint_invalidation_state(
415 paint_invalidation_state, *child_layout_view); 415 paint_invalidation_state, *child_layout_view);
416 frame_view->InvalidateTreeIfNeeded(child_view_paint_invalidation_state); 416 frame_view->DeprecatedInvalidateTree(child_view_paint_invalidation_state);
417 } 417 }
418 } 418 }
419 419
420 LayoutReplaced::InvalidatePaintOfSubtreesIfNeeded(paint_invalidation_state); 420 LayoutReplaced::DeprecatedInvalidatePaintOfSubtrees(paint_invalidation_state);
421 } 421 }
422 422
423 bool LayoutPart::IsThrottledFrameView() const { 423 bool LayoutPart::IsThrottledFrameView() const {
424 if (FrameView* frame_view = ChildFrameView()) 424 if (FrameView* frame_view = ChildFrameView())
425 return frame_view->ShouldThrottleRendering(); 425 return frame_view->ShouldThrottleRendering();
426 return false; 426 return false;
427 } 427 }
428 428
429 } // namespace blink 429 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutPart.h ('k') | third_party/WebKit/Source/core/layout/LayoutTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698