Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1867 matching lines...) Expand 10 before | Expand all | Expand 10 after
1878 return; 1878 return;
1879 1879
1880 // Do regular full paint invalidation if the object with 1880 // Do regular full paint invalidation if the object with
1881 // kPaintInvalidationDelayedFull is onscreen. 1881 // kPaintInvalidationDelayedFull is onscreen.
1882 // Conservatively assume the delayed paint invalidation was caused by 1882 // Conservatively assume the delayed paint invalidation was caused by
1883 // background image change. 1883 // background image change.
1884 SetBackgroundChangedSinceLastPaintInvalidation(); 1884 SetBackgroundChangedSinceLastPaintInvalidation();
1885 SetShouldDoFullPaintInvalidationWithoutGeometryChange(kPaintInvalidationFull); 1885 SetShouldDoFullPaintInvalidationWithoutGeometryChange(kPaintInvalidationFull);
1886 } 1886 }
1887 1887
1888 PaintInvalidationReason LayoutBox::InvalidatePaint( 1888 PaintInvalidationReason LayoutBox::DeprecatedInvalidatePaint(
1889 const PaintInvalidationState& paint_invalidation_state) { 1889 const PaintInvalidationState& paint_invalidation_state) {
1890 if (HasBoxDecorationBackground() 1890 if (HasBoxDecorationBackground()
1891 // We also paint overflow controls in background phase. 1891 // We also paint overflow controls in background phase.
1892 || (HasOverflowClip() && GetScrollableArea()->HasOverflowControls())) { 1892 || (HasOverflowClip() && GetScrollableArea()->HasOverflowControls())) {
1893 PaintLayer& layer = paint_invalidation_state.PaintingLayer(); 1893 PaintLayer& layer = paint_invalidation_state.PaintingLayer();
1894 if (&layer.GetLayoutObject() != this) 1894 if (&layer.GetLayoutObject() != this)
1895 layer.SetNeedsPaintPhaseDescendantBlockBackgrounds(); 1895 layer.SetNeedsPaintPhaseDescendantBlockBackgrounds();
1896 } 1896 }
1897 1897
1898 return LayoutBoxModelObject::InvalidatePaint(paint_invalidation_state); 1898 return LayoutBoxModelObject::DeprecatedInvalidatePaint(
1899 paint_invalidation_state);
1899 } 1900 }
1900 1901
1901 PaintInvalidationReason LayoutBox::InvalidatePaint( 1902 PaintInvalidationReason LayoutBox::InvalidatePaint(
1902 const PaintInvalidatorContext& context) const { 1903 const PaintInvalidatorContext& context) const {
1903 return BoxPaintInvalidator(*this, context).InvalidatePaint(); 1904 return BoxPaintInvalidator(*this, context).InvalidatePaint();
1904 } 1905 }
1905 1906
1906 LayoutRect LayoutBox::OverflowClipRect( 1907 LayoutRect LayoutBox::OverflowClipRect(
1907 const LayoutPoint& location, 1908 const LayoutPoint& location,
1908 OverlayScrollbarClipBehavior overlay_scrollbar_clip_behavior) const { 1909 OverlayScrollbarClipBehavior overlay_scrollbar_clip_behavior) const {
(...skipping 3990 matching lines...) Expand 10 before | Expand all | Expand 10 after
5899 void LayoutBox::MutableForPainting:: 5900 void LayoutBox::MutableForPainting::
5900 SavePreviousContentBoxSizeAndLayoutOverflowRect() { 5901 SavePreviousContentBoxSizeAndLayoutOverflowRect() {
5901 auto& rare_data = GetLayoutBox().EnsureRareData(); 5902 auto& rare_data = GetLayoutBox().EnsureRareData();
5902 rare_data.has_previous_content_box_size_and_layout_overflow_rect_ = true; 5903 rare_data.has_previous_content_box_size_and_layout_overflow_rect_ = true;
5903 rare_data.previous_content_box_size_ = GetLayoutBox().ContentBoxRect().Size(); 5904 rare_data.previous_content_box_size_ = GetLayoutBox().ContentBoxRect().Size();
5904 rare_data.previous_layout_overflow_rect_ = 5905 rare_data.previous_layout_overflow_rect_ =
5905 GetLayoutBox().LayoutOverflowRect(); 5906 GetLayoutBox().LayoutOverflowRect();
5906 } 5907 }
5907 5908
5908 } // namespace blink 5909 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698