Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 875 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 886
887 public: 887 public:
888 explicit InUpdateScrollbarsScope(FrameView* view) 888 explicit InUpdateScrollbarsScope(FrameView* view)
889 : scope_(&view->in_update_scrollbars_, true) {} 889 : scope_(&view->in_update_scrollbars_, true) {}
890 890
891 private: 891 private:
892 AutoReset<bool> scope_; 892 AutoReset<bool> scope_;
893 }; 893 };
894 894
895 // Only for LayoutPart to traverse into sub frames during paint invalidation. 895 // Only for LayoutPart to traverse into sub frames during paint invalidation.
896 void InvalidateTreeIfNeeded(const PaintInvalidationState&); 896 void DeprecatedInvalidateTree(const PaintInvalidationState&);
897 897
898 private: 898 private:
899 explicit FrameView(LocalFrame&, IntRect); 899 explicit FrameView(LocalFrame&, IntRect);
900 class ScrollbarManager : public blink::ScrollbarManager { 900 class ScrollbarManager : public blink::ScrollbarManager {
901 DISALLOW_NEW(); 901 DISALLOW_NEW();
902 902
903 // Helper class to manage the life cycle of Scrollbar objects. 903 // Helper class to manage the life cycle of Scrollbar objects.
904 public: 904 public:
905 ScrollbarManager(FrameView& scroller) : blink::ScrollbarManager(scroller) {} 905 ScrollbarManager(FrameView& scroller) : blink::ScrollbarManager(scroller) {}
906 906
(...skipping 13 matching lines...) Expand all
920 void UpdateScrollbarEnabledState(); 920 void UpdateScrollbarEnabledState();
921 921
922 void DispatchEventsForPrintingOnAllFrames(); 922 void DispatchEventsForPrintingOnAllFrames();
923 923
924 void SetupPrintContext(); 924 void SetupPrintContext();
925 void ClearPrintContext(); 925 void ClearPrintContext();
926 926
927 void UpdateLifecyclePhasesInternal( 927 void UpdateLifecyclePhasesInternal(
928 DocumentLifecycle::LifecycleState target_state); 928 DocumentLifecycle::LifecycleState target_state);
929 929
930 void InvalidateTreeIfNeededRecursive(); 930 void DeprecatedInvalidateTreeRecursive();
931 void ScrollContentsIfNeededRecursive(); 931 void ScrollContentsIfNeededRecursive();
932 void UpdateStyleAndLayoutIfNeededRecursive(); 932 void UpdateStyleAndLayoutIfNeededRecursive();
933 void PrePaint(); 933 void PrePaint();
934 void PaintTree(); 934 void PaintTree();
935 void PaintGraphicsLayerRecursively(GraphicsLayer*); 935 void PaintGraphicsLayerRecursively(GraphicsLayer*);
936 936
937 void UpdateStyleAndLayoutIfNeededRecursiveInternal(); 937 void UpdateStyleAndLayoutIfNeededRecursiveInternal();
938 void InvalidateTreeIfNeededRecursiveInternal(); 938 void DeprecatedInvalidateTreeRecursiveInternal();
939 939
940 // TODO(wangxianzhu): Remove the parameter and use m_paintController for SPv2. 940 // TODO(wangxianzhu): Remove the parameter and use m_paintController for SPv2.
941 void NotifyPaint(const PaintController&) const; 941 void NotifyPaint(const PaintController&) const;
942 void PushPaintArtifactToCompositor( 942 void PushPaintArtifactToCompositor(
943 CompositorElementIdSet& composited_element_ids); 943 CompositorElementIdSet& composited_element_ids);
944 944
945 void Reset(); 945 void Reset();
946 void Init(); 946 void Init();
947 947
948 void ClearLayoutSubtreeRootsAndMarkContainingBlocks(); 948 void ClearLayoutSubtreeRootsAndMarkContainingBlocks();
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1275 frameViewBase.IsFrameView()); 1275 frameViewBase.IsFrameView());
1276 DEFINE_TYPE_CASTS(FrameView, 1276 DEFINE_TYPE_CASTS(FrameView,
1277 ScrollableArea, 1277 ScrollableArea,
1278 scrollableArea, 1278 scrollableArea,
1279 scrollableArea->IsFrameView(), 1279 scrollableArea->IsFrameView(),
1280 scrollableArea.IsFrameView()); 1280 scrollableArea.IsFrameView());
1281 1281
1282 } // namespace blink 1282 } // namespace blink
1283 1283
1284 #endif // FrameView_h 1284 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698