Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index ba11080d1292f01d6b4864497998fd6e55cbb228..f9da27f0efe35a3a26bdad096795891aac51c436 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1134,7 +1134,7 @@ LayoutRect LayoutObject::InvalidatePaintRectangle(
dirty_rect, display_item_client);
}
-void LayoutObject::InvalidateTreeIfNeeded(
+void LayoutObject::DeprecatedInvalidateTree(
const PaintInvalidationState& paint_invalidation_state) {
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
EnsureIsReadyForPaintInvalidation();
@@ -1154,20 +1154,20 @@ void LayoutObject::InvalidateTreeIfNeeded(
}
PaintInvalidationReason reason =
- InvalidatePaint(new_paint_invalidation_state);
+ DeprecatedInvalidatePaint(new_paint_invalidation_state);
new_paint_invalidation_state.UpdateForChildren(reason);
- InvalidatePaintOfSubtreesIfNeeded(new_paint_invalidation_state);
+ DeprecatedInvalidatePaintOfSubtrees(new_paint_invalidation_state);
ClearPaintInvalidationFlags();
}
DISABLE_CFI_PERF
-void LayoutObject::InvalidatePaintOfSubtreesIfNeeded(
+void LayoutObject::DeprecatedInvalidatePaintOfSubtrees(
const PaintInvalidationState& child_paint_invalidation_state) {
DCHECK(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
for (auto* child = SlowFirstChild(); child; child = child->NextSibling())
- child->InvalidateTreeIfNeeded(child_paint_invalidation_state);
+ child->DeprecatedInvalidateTree(child_paint_invalidation_state);
}
LayoutRect LayoutObject::SelectionRectInViewCoordinates() const {
@@ -1177,7 +1177,7 @@ LayoutRect LayoutObject::SelectionRectInViewCoordinates() const {
return selection_rect;
}
-PaintInvalidationReason LayoutObject::InvalidatePaint(
+PaintInvalidationReason LayoutObject::DeprecatedInvalidatePaint(
const PaintInvalidationState& paint_invalidation_state) {
DCHECK_EQ(&paint_invalidation_state.CurrentObject(), this);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/LayoutPart.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698