Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2851453005: Mark some non-spinvalidation methods deprecated, and update paint/README.md (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 // implemented by any subclass, and since a hierarchy can contain a mixture of 260 // implemented by any subclass, and since a hierarchy can contain a mixture of
261 // boxes and other object types, these functions need to be in the base class. 261 // boxes and other object types, these functions need to be in the base class.
262 PaintLayer* EnclosingLayer() const; 262 PaintLayer* EnclosingLayer() const;
263 void AddLayers(PaintLayer* parent_layer); 263 void AddLayers(PaintLayer* parent_layer);
264 void RemoveLayers(PaintLayer* parent_layer); 264 void RemoveLayers(PaintLayer* parent_layer);
265 void MoveLayers(PaintLayer* old_parent, PaintLayer* new_parent); 265 void MoveLayers(PaintLayer* old_parent, PaintLayer* new_parent);
266 PaintLayer* FindNextLayer(PaintLayer* parent_layer, 266 PaintLayer* FindNextLayer(PaintLayer* parent_layer,
267 LayoutObject* start_point, 267 LayoutObject* start_point,
268 bool check_parent = true); 268 bool check_parent = true);
269 269
270 // Returns the layer that will paint this object. If possible, use the faster 270 // Returns the layer that will paint this object. During paint invalidation,
271 // PaintInvalidationState::paintingLayer() instead. 271 // we should use the faster PaintInvalidatorContext::painting_layer instead.
272 PaintLayer* PaintingLayer() const; 272 PaintLayer* PaintingLayer() const;
273 273
274 // Scrolling is a LayoutBox concept, however some code just cares about 274 // Scrolling is a LayoutBox concept, however some code just cares about
275 // recursively scrolling our enclosing ScrollableArea(s). 275 // recursively scrolling our enclosing ScrollableArea(s).
276 bool ScrollRectToVisible( 276 bool ScrollRectToVisible(
277 const LayoutRect&, 277 const LayoutRect&,
278 const ScrollAlignment& align_x = ScrollAlignment::kAlignCenterIfNeeded, 278 const ScrollAlignment& align_x = ScrollAlignment::kAlignCenterIfNeeded,
279 const ScrollAlignment& align_y = ScrollAlignment::kAlignCenterIfNeeded, 279 const ScrollAlignment& align_y = ScrollAlignment::kAlignCenterIfNeeded,
280 ScrollType = kProgrammaticScroll, 280 ScrollType = kProgrammaticScroll,
281 bool make_visible_in_visual_viewport = true); 281 bool make_visible_in_visual_viewport = true);
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1382 // If a DisplayItemClient is specified, that client is invalidated rather than 1382 // If a DisplayItemClient is specified, that client is invalidated rather than
1383 // |this|. 1383 // |this|.
1384 // Returns the visual rect that was invalidated (i.e, invalidation in the 1384 // Returns the visual rect that was invalidated (i.e, invalidation in the
1385 // space of the GraphicsLayer backing this LayoutObject). 1385 // space of the GraphicsLayer backing this LayoutObject).
1386 LayoutRect InvalidatePaintRectangle(const LayoutRect&, 1386 LayoutRect InvalidatePaintRectangle(const LayoutRect&,
1387 DisplayItemClient* = nullptr) const; 1387 DisplayItemClient* = nullptr) const;
1388 1388
1389 // Walk the tree after layout issuing paint invalidations for layoutObjects 1389 // Walk the tree after layout issuing paint invalidations for layoutObjects
1390 // that have changed or moved, updating bounds that have changed, and clearing 1390 // that have changed or moved, updating bounds that have changed, and clearing
1391 // paint invalidation state. 1391 // paint invalidation state.
1392 virtual void InvalidateTreeIfNeeded(const PaintInvalidationState&); 1392 virtual void DeprecatedInvalidateTree(const PaintInvalidationState&);
1393 1393
1394 void SetShouldDoFullPaintInvalidationIncludingNonCompositingDescendants(); 1394 void SetShouldDoFullPaintInvalidationIncludingNonCompositingDescendants();
1395 1395
1396 // Returns the rect that should have paint invalidated whenever this object 1396 // Returns the rect that should have paint invalidated whenever this object
1397 // changes. The rect is in the view's coordinate space. This method deals with 1397 // changes. The rect is in the view's coordinate space. This method deals with
1398 // outlines and overflow. 1398 // outlines and overflow.
1399 virtual LayoutRect AbsoluteVisualRect() const; 1399 virtual LayoutRect AbsoluteVisualRect() const;
1400 1400
1401 // Returns the rect that should have paint invalidated whenever this object 1401 // Returns the rect that should have paint invalidated whenever this object
1402 // changes. The rect is in the object's local coordinate space. This is for 1402 // changes. The rect is in the object's local coordinate space. This is for
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
2070 virtual void EnsureIsReadyForPaintInvalidation() { DCHECK(!NeedsLayout()); } 2070 virtual void EnsureIsReadyForPaintInvalidation() { DCHECK(!NeedsLayout()); }
2071 2071
2072 // This function walks the descendants of |this|, following a 2072 // This function walks the descendants of |this|, following a
2073 // layout ordering. 2073 // layout ordering.
2074 // 2074 //
2075 // The ordering is important for PaintInvalidationState, as it requires to be 2075 // The ordering is important for PaintInvalidationState, as it requires to be
2076 // called following a descendant/container relationship. 2076 // called following a descendant/container relationship.
2077 // 2077 //
2078 // The function is overridden to handle special children (e.g. percentage 2078 // The function is overridden to handle special children (e.g. percentage
2079 // height descendants or reflections). 2079 // height descendants or reflections).
2080 virtual void InvalidatePaintOfSubtreesIfNeeded( 2080 virtual void DeprecatedInvalidatePaintOfSubtrees(
2081 const PaintInvalidationState& child_paint_invalidation_state); 2081 const PaintInvalidationState& child_paint_invalidation_state);
2082 2082
2083 // This function generates the invalidation for this object only. 2083 // This function generates the invalidation for this object only.
2084 // It doesn't recurse into other object, as this is handled by 2084 // It doesn't recurse into other object, as this is handled by
2085 // invalidatePaintOfSubtreesIfNeeded. 2085 // DeprecatedInvalidatePaintOfSubtrees.
2086 virtual PaintInvalidationReason InvalidatePaint( 2086 virtual PaintInvalidationReason DeprecatedInvalidatePaint(
2087 const PaintInvalidationState&); 2087 const PaintInvalidationState&);
2088 2088
2089 void SetIsBackgroundAttachmentFixedObject(bool); 2089 void SetIsBackgroundAttachmentFixedObject(bool);
2090 2090
2091 void ClearSelfNeedsOverflowRecalcAfterStyleChange() { 2091 void ClearSelfNeedsOverflowRecalcAfterStyleChange() {
2092 bitfields_.SetSelfNeedsOverflowRecalcAfterStyleChange(false); 2092 bitfields_.SetSelfNeedsOverflowRecalcAfterStyleChange(false);
2093 } 2093 }
2094 void SetEverHadLayout() { bitfields_.SetEverHadLayout(true); } 2094 void SetEverHadLayout() { bitfields_.SetEverHadLayout(true); }
2095 2095
2096 // Remove this object and all descendants from the containing 2096 // Remove this object and all descendants from the containing
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
2818 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2818 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2819 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2819 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2820 // We don't make object2 an optional parameter so that showLayoutTree 2820 // We don't make object2 an optional parameter so that showLayoutTree
2821 // can be called from gdb easily. 2821 // can be called from gdb easily.
2822 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2822 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2823 const blink::LayoutObject* object2); 2823 const blink::LayoutObject* object2);
2824 2824
2825 #endif 2825 #endif
2826 2826
2827 #endif // LayoutObject_h 2827 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698