[blink] Unique pointers in Platform.h

[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Original-Commit-Position: refs/heads/master@{#467710}
Committed: https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc08853940134707fcd6c455
Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#468697}
Committed: https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91a117583f9786
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468969}
Committed: https://chromium.googlesource.com/chromium/src/+/eb6bd1966e3d4605bb8cc911764889ebf0597129

[altimin, 2017-04-27 10:28:48]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[altimin, 2017-04-27 10:30:11]

altimin@chromium.org changed reviewers:
+ clamy@chromium.org, haraken@chromium.org, tdresser@chromium.org

[altimin, 2017-04-27 10:30:12]

PTAL

+haraken@ for blink
+clamy@ for content
+tdresser for ui

[altimin, 2017-04-27 10:33:31]

altimin@chromium.org changed reviewers:
+ thakis@chromium.org

[altimin, 2017-04-27 10:33:32]

And +thakis@ for chrome/

[altimin, 2017-04-27 10:33:44]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 10:33:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 10:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 10:44:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[altimin, 2017-04-27 11:14:33]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 11:14:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 11:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 11:29:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2017-04-27 11:45:59]

WebKit LGTM

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
(right):

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp:103:
return base::MakeUnique<MockWebRTCPeerConnectionHandler>();

WTF::MakeUnique ?

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebFlingAnimator.h (left):

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebFlingAnimator.h:35: class WebFlingAnimator
{

Is this class unused?

[tdresser, 2017-04-27 11:52:22]

ui LGTM

[altimin, 2017-04-27 11:56:14]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 11:56:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-04-27 11:57:08]

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
(right):

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp:103:
return base::MakeUnique<MockWebRTCPeerConnectionHandler>();
On 2017/04/27 11:45:59, haraken wrote:
> 
> WTF::MakeUnique ?

Done.

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebFlingAnimator.h (left):

https://codereview.chromium.org/2846843002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebFlingAnimator.h:35: class WebFlingAnimator
{
On 2017/04/27 11:45:59, haraken wrote:
> 
> Is this class unused?

Yes.

[clamy, 2017-04-27 12:00:18]

Thanks! I'm mostly happy with the code, a few comments below.

https://codereview.chromium.org/2846843002/diff/20001/content/ppapi_plugin/pp...
File content/ppapi_plugin/ppapi_blink_platform_impl.cc (right):

https://codereview.chromium.org/2846843002/diff/20001/content/ppapi_plugin/pp...
content/ppapi_plugin/ppapi_blink_platform_impl.cc:229: return 0;
I'd rather we return nullptr here.

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
File content/renderer/media/renderer_webaudiodevice_impl.cc (right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
content/renderer/media/renderer_webaudiodevice_impl.cc:114: return
std::unique_ptr<RendererWebAudioDeviceImpl>(
Could we use base::MakeUnique?

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
File content/renderer/media_capture_from_element/canvas_capture_handler.cc
(right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
content/renderer/media_capture_from_element/canvas_capture_handler.cc:154:
return std::unique_ptr<CanvasCaptureHandler>(
Could we use base::MakeUnique?

[altimin, 2017-04-27 12:06:30]

https://codereview.chromium.org/2846843002/diff/20001/content/ppapi_plugin/pp...
File content/ppapi_plugin/ppapi_blink_platform_impl.cc (right):

https://codereview.chromium.org/2846843002/diff/20001/content/ppapi_plugin/pp...
content/ppapi_plugin/ppapi_blink_platform_impl.cc:229: return 0;
On 2017/04/27 12:00:18, clamy wrote:
> I'd rather we return nullptr here.

Done.

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
File content/renderer/media/renderer_webaudiodevice_impl.cc (right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
content/renderer/media/renderer_webaudiodevice_impl.cc:114: return
std::unique_ptr<RendererWebAudioDeviceImpl>(
On 2017/04/27 12:00:18, clamy wrote:
> Could we use base::MakeUnique?

RendererWebAudioDeviceImpl's constructor is private. Not sure if we want to
change this.

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
File content/renderer/media_capture_from_element/canvas_capture_handler.cc
(right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
content/renderer/media_capture_from_element/canvas_capture_handler.cc:154:
return std::unique_ptr<CanvasCaptureHandler>(
On 2017/04/27 12:00:18, clamy wrote:
> Could we use base::MakeUnique?

Same, constructor is private.

[altimin, 2017-04-27 12:06:39]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 12:06:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[clamy, 2017-04-27 12:12:49]

Thanks! content/ lgtm.

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
File content/renderer/media/renderer_webaudiodevice_impl.cc (right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media/...
content/renderer/media/renderer_webaudiodevice_impl.cc:114: return
std::unique_ptr<RendererWebAudioDeviceImpl>(
On 2017/04/27 12:06:30, altimin wrote:
> On 2017/04/27 12:00:18, clamy wrote:
> > Could we use base::MakeUnique?
> 
> RendererWebAudioDeviceImpl's constructor is private. Not sure if we want to
> change this.

Acknowledged.

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
File content/renderer/media_capture_from_element/canvas_capture_handler.cc
(right):

https://codereview.chromium.org/2846843002/diff/20001/content/renderer/media_...
content/renderer/media_capture_from_element/canvas_capture_handler.cc:154:
return std::unique_ptr<CanvasCaptureHandler>(
On 2017/04/27 12:06:30, altimin wrote:
> On 2017/04/27 12:00:18, clamy wrote:
> > Could we use base::MakeUnique?
> 
> Same, constructor is private.

Acknowledged.

[altimin, 2017-04-27 12:14:57]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 12:15:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 12:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 12:38:05]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Nico, 2017-04-27 14:23:01]

chrome/ lgtm

[altimin, 2017-04-27 14:41:20]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 14:41:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 16:37:47]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-04-27 16:41:00]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-04-27 16:41:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tdresser@chromium.org, clamy@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2846843002/#ps100001
(title: "fix compilation on android (maybe)")

[commit-bot: I haz the power, 2017-04-27 16:41:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 16:49:47]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493311260523680,
"parent_rev": "e2d622806d0648f17eac947bd9d77b29211ccc2f", "commit_rev":
"d548cc04b6568f8edc08853940134707fcd6c455"}

[commit-bot: I haz the power, 2017-04-27 16:52:23]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
==========

[commit-bot: I haz the power, 2017-04-27 16:52:26]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...

[altimin, 2017-04-27 17:39:11]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2850593002/ by altimin@chromium.org.

The reason for reverting is: Broke the tree.

[findit-for-me, 2017-04-27 17:48:28]

Findit(https://goo.gl/kROfz5) confirmed this CL at revision 467710 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[altimin1, 2017-05-02 15:02:42]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
==========

[altimin, 2017-05-02 15:04:21]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 15:04:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 15:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:26:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2017-05-02 15:30:28]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 15:31:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 17:12:25]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-05-02 17:17:40]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-05-02 17:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, clamy@chromium.org, thakis@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2846843002/#ps140001
(title: "fix compilation (and again)")

[commit-bot: I haz the power, 2017-05-02 17:17:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493745460728190,
"parent_rev": "871cf26beba2d57135b55a6c45bce9cef53993cc", "commit_rev":
"bd3351963fb4da3e31478d841b91a117583f9786"}

[commit-bot: I haz the power, 2017-05-02 17:28:52]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468697}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...
==========

[commit-bot: I haz the power, 2017-05-02 17:28:55]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...

[altimin, 2017-05-02 18:06:32]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2859553002/ by altimin@chromium.org.

The reason for reverting is: More cast audio linux compile failures..

[findit-for-me, 2017-05-02 18:12:31]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468697 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[altimin, 2017-05-02 18:25:53]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468697}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468697}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...
==========

[altimin, 2017-05-02 18:31:41]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 18:32:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 20:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:50:50]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-05-03 10:48:48]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-05-03 10:48:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, clamy@chromium.org, thakis@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2846843002/#ps180001
(title: "fix compilation (and again)")

[commit-bot: I haz the power, 2017-05-03 10:49:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 10:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 10:57:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[altimin, 2017-05-03 11:20:55]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 11:21:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-05-03 12:02:40]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 12:02:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-05-03 12:03:48]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 12:04:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 14:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 14:24:36]

Dry run: This issue passed the CQ dry run.

[altimin, 2017-05-03 14:41:50]

The CQ bit was checked by altimin@chromium.org

[altimin, 2017-05-03 14:41:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, clamy@chromium.org, thakis@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2846843002/#ps200001
(title: "fix compilation (and again)")

[commit-bot: I haz the power, 2017-05-03 14:42:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 14:52:42]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1493822510855930,
"parent_rev": "e0c3dab76ce9e7b066b4b591c9cf5b0a9a856f3e", "commit_rev":
"eb6bd1966e3d4605bb8cc911764889ebf0597129"}

[commit-bot: I haz the power, 2017-05-03 14:52:53]

Description was changed from

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468697}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...
==========

to

==========
[blink] Unique pointers in Platform.h

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Original-Commit-Position: refs/heads/master@{#467710}
Committed:
https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc0885394013...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#468697}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91...
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468969}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb6bd1966e3d4605bb8cc9117648...
==========

[commit-bot: I haz the power, 2017-05-03 14:52:59]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/eb6bd1966e3d4605bb8cc9117648...