third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2846843002: [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)

Patch Set: fix compilation (and again) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | third_party/WebKit/Source/modules/storage/StorageNamespace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index 9cd0c9a71c4865b6324dfb1fd2540fafd607fd7b..c1f8016bf39604cb268a4731cdf76a064d8da59a 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -503,8 +503,7 @@ RTCPeerConnection::RTCPeerConnection(ExecutionContext* context,

return;

}

- peer_handler_ = WTF::WrapUnique(

- Platform::Current()->CreateRTCPeerConnectionHandler(this));

+ peer_handler_ = Platform::Current()->CreateRTCPeerConnectionHandler(this);

if (!peer_handler_) {

closed_ = true;

stopped_ = true;

@@ -925,7 +924,7 @@ ScriptPromise RTCPeerConnection::generateCertificate(

DCHECK(!key_params.IsNull());

std::unique_ptr<WebRTCCertificateGenerator> certificate_generator =

- WTF::WrapUnique(Platform::Current()->CreateRTCCertificateGenerator());

+ Platform::Current()->CreateRTCCertificateGenerator();

// |keyParams| was successfully constructed, but does the certificate

// generator support these parameters?