Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)
Patch Set: fix compilation (and again) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/BUILD.gn ('k') | third_party/WebKit/public/platform/WebFlingAnimator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/Platform.h
diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h
index 53ecbcdbe673ec7328e0f9a333d9ad98367ddfe1..86c66e5bb294c1272686122a0dbc36e6c92fad1a 100644
--- a/third_party/WebKit/public/platform/Platform.h
+++ b/third_party/WebKit/public/platform/Platform.h
@@ -93,7 +93,6 @@ class WebPlatformEventListener;
class WebFallbackThemeEngine;
class WebFileSystem;
class WebFileUtilities;
-class WebFlingAnimator;
class WebGestureCurve;
class WebGraphicsContext3DProvider;
class WebIDBFactory;
@@ -169,7 +168,7 @@ class BLINK_PLATFORM_EXPORT Platform {
virtual WebFallbackThemeEngine* FallbackThemeEngine() { return nullptr; }
// May return null.
- virtual WebSpeechSynthesizer* CreateSpeechSynthesizer(
+ virtual std::unique_ptr<WebSpeechSynthesizer> CreateSpeechSynthesizer(
WebSpeechSynthesizerClient*) {
return nullptr;
}
@@ -182,7 +181,7 @@ class BLINK_PLATFORM_EXPORT Platform {
// Creates a device for audio I/O.
// Pass in (numberOfInputChannels > 0) if live/local audio input is desired.
- virtual WebAudioDevice* CreateAudioDevice(
+ virtual std::unique_ptr<WebAudioDevice> CreateAudioDevice(
unsigned number_of_input_channels,
unsigned number_of_channels,
const WebAudioLatencyHint& latency_hint,
@@ -196,9 +195,8 @@ class BLINK_PLATFORM_EXPORT Platform {
// Creates a platform dependent WebMIDIAccessor. MIDIAccessor under platform
// creates and owns it.
- virtual WebMIDIAccessor* CreateMIDIAccessor(WebMIDIAccessorClient*) {
- return nullptr;
- }
+ virtual std::unique_ptr<WebMIDIAccessor> CreateMIDIAccessor(
+ WebMIDIAccessorClient*);
// Blob ----------------------------------------------------------------
@@ -251,7 +249,7 @@ class BLINK_PLATFORM_EXPORT Platform {
// DOM Storage --------------------------------------------------
// Return a LocalStorage namespace
- virtual WebStorageNamespace* CreateLocalStorageNamespace() { return nullptr; }
+ virtual std::unique_ptr<WebStorageNamespace> CreateLocalStorageNamespace();
// FileSystem ----------------------------------------------------------
@@ -275,10 +273,8 @@ class BLINK_PLATFORM_EXPORT Platform {
// Cache Storage ----------------------------------------------------------
- // The caller is responsible for deleting the returned object.
- virtual WebServiceWorkerCacheStorage* CacheStorage(const WebSecurityOrigin&) {
- return nullptr;
- }
+ virtual std::unique_ptr<WebServiceWorkerCacheStorage> CreateCacheStorage(
+ const WebSecurityOrigin&);
// Gamepad -------------------------------------------------------------
@@ -394,7 +390,7 @@ class BLINK_PLATFORM_EXPORT Platform {
// Threads -------------------------------------------------------
// Creates an embedder-defined thread.
- virtual WebThread* CreateThread(const char* name) { return nullptr; }
+ virtual std::unique_ptr<WebThread> CreateThread(const char* name);
// Returns an interface to the current thread. This is owned by the
// embedder.
@@ -496,22 +492,18 @@ class BLINK_PLATFORM_EXPORT Platform {
// created or initialized.
// Passing an existing provider to shareContext will create the new context
// in the same share group as the one passed.
- virtual WebGraphicsContext3DProvider*
+ virtual std::unique_ptr<WebGraphicsContext3DProvider>
CreateOffscreenGraphicsContext3DProvider(
const ContextAttributes&,
const WebURL& top_document_url,
WebGraphicsContext3DProvider* share_context,
- GraphicsInfo*) {
- return nullptr;
- }
+ GraphicsInfo*);
// Returns a newly allocated and initialized offscreen context provider,
// backed by the process-wide shared main thread context. Returns null if
// the context cannot be created or initialized.
- virtual WebGraphicsContext3DProvider*
- CreateSharedOffscreenGraphicsContext3DProvider() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebGraphicsContext3DProvider>
+ CreateSharedOffscreenGraphicsContext3DProvider();
virtual gpu::GpuMemoryBufferManager* GetGpuMemoryBufferManager() {
return nullptr;
@@ -527,16 +519,12 @@ class BLINK_PLATFORM_EXPORT Platform {
virtual WebCompositorSupport* CompositorSupport() { return nullptr; }
- virtual WebFlingAnimator* CreateFlingAnimator() { return nullptr; }
-
// Creates a new fling animation curve instance for device |deviceSource|
// with |velocity| and already scrolled |cumulativeScroll| pixels.
- virtual WebGestureCurve* CreateFlingAnimationCurve(
+ virtual std::unique_ptr<WebGestureCurve> CreateFlingAnimationCurve(
WebGestureDevice device_source,
const WebFloatPoint& velocity,
- const WebSize& cumulative_scroll) {
- return nullptr;
- }
+ const WebSize& cumulative_scroll);
// Whether the command line flag: --disable-gpu-compositing or --disable-gpu
// exists or not
@@ -549,35 +537,26 @@ class BLINK_PLATFORM_EXPORT Platform {
// Creates a WebRTCPeerConnectionHandler for RTCPeerConnection.
// May return null if WebRTC functionality is not avaliable or if it's out of
// resources.
- virtual WebRTCPeerConnectionHandler* CreateRTCPeerConnectionHandler(
- WebRTCPeerConnectionHandlerClient*) {
- return nullptr;
- }
+ virtual std::unique_ptr<WebRTCPeerConnectionHandler>
+ CreateRTCPeerConnectionHandler(WebRTCPeerConnectionHandlerClient*);
// Creates a WebMediaRecorderHandler to record MediaStreams.
// May return null if the functionality is not available or out of resources.
- virtual WebMediaRecorderHandler* CreateMediaRecorderHandler() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebMediaRecorderHandler> CreateMediaRecorderHandler();
// May return null if WebRTC functionality is not available or out of
// resources.
- virtual WebRTCCertificateGenerator* CreateRTCCertificateGenerator() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebRTCCertificateGenerator>
+ CreateRTCCertificateGenerator();
// May return null if WebRTC functionality is not available or out of
// resources.
- virtual WebMediaStreamCenter* CreateMediaStreamCenter(
- WebMediaStreamCenterClient*) {
- return nullptr;
- }
+ virtual std::unique_ptr<WebMediaStreamCenter> CreateMediaStreamCenter(
+ WebMediaStreamCenterClient*);
// Creates a WebCanvasCaptureHandler to capture Canvas output.
- virtual WebCanvasCaptureHandler*
- CreateCanvasCaptureHandler(const WebSize&, double, WebMediaStreamTrack*) {
- return nullptr;
- }
+ virtual std::unique_ptr<WebCanvasCaptureHandler>
+ CreateCanvasCaptureHandler(const WebSize&, double, WebMediaStreamTrack*);
// Fills in the WebMediaStream to capture from the WebMediaPlayer identified
// by the second parameter.
@@ -588,9 +567,8 @@ class BLINK_PLATFORM_EXPORT Platform {
// Creates a WebImageCaptureFrameGrabber to take a snapshot of a Video Tracks.
// May return null if the functionality is not available.
- virtual WebImageCaptureFrameGrabber* CreateImageCaptureFrameGrabber() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebImageCaptureFrameGrabber>
+ CreateImageCaptureFrameGrabber();
// WebWorker ----------------------------------------------------------
@@ -697,21 +675,17 @@ class BLINK_PLATFORM_EXPORT Platform {
// document's policy (may be nullptr), its container policy (may be empty),
// the header policy with which it was delivered (may be empty), and the
// document's origin.
- virtual WebFeaturePolicy* CreateFeaturePolicy(
+ virtual std::unique_ptr<WebFeaturePolicy> CreateFeaturePolicy(
const WebFeaturePolicy* parent_policy,
const WebParsedFeaturePolicy& container_policy,
const WebParsedFeaturePolicy& policy_header,
- const WebSecurityOrigin&) {
- return nullptr;
- }
+ const WebSecurityOrigin&);
// Create a new feature policy for a document whose origin has changed, given
// the previous policy object and the new origin.
- virtual WebFeaturePolicy* DuplicateFeaturePolicyWithOrigin(
+ virtual std::unique_ptr<WebFeaturePolicy> DuplicateFeaturePolicyWithOrigin(
const WebFeaturePolicy&,
- const WebSecurityOrigin&) {
- return nullptr;
- }
+ const WebSecurityOrigin&);
protected:
Platform();
« no previous file with comments | « third_party/WebKit/public/BUILD.gn ('k') | third_party/WebKit/public/platform/WebFlingAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698