third_party/WebKit/Source/modules/storage/StorageNamespace.cpp - Issue 2846843002: [blink] Unique pointers in Platform.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

Issue 2846843002: [blink] Unique pointers in Platform.h (Closed)

Patch Set: fix compilation (and again) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

diff --git a/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp b/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

index ea002bb83227a1900622ee591d8252b7dbae9ec1..2b62537e08acc5a456108471526d871865ba03c9 100644

--- a/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

+++ b/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp

@@ -44,7 +44,7 @@ StorageNamespace::~StorageNamespace() {}

StorageArea* StorageNamespace::LocalStorageArea(SecurityOrigin* origin) {

DCHECK(IsMainThread());

- static WebStorageNamespace* local_storage_namespace = nullptr;

+ static std::unique_ptr<WebStorageNamespace> local_storage_namespace = nullptr;

if (!local_storage_namespace)

local_storage_namespace =

Platform::Current()->CreateLocalStorageNamespace();