Enable use_once_callback on mojom GN rule by default

Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag on affected rules, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843353004
Cr-Commit-Position: refs/heads/master@{#470858}
Committed: https://chromium.googlesource.com/chromium/src/+/0639e21a33c73f3e316ce84a490b1d50ceaa024b

[tzik, 2017-04-27 14:09:50]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

BUG=
==========

to

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-04-27 14:09:52]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-04-27 14:27:40]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 14:28:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 14:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 14:40:03]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[tzik, 2017-04-28 09:19:26]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 09:19:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 09:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 09:33:34]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[tzik, 2017-04-28 09:53:37]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 09:53:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 10:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 10:04:44]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tzik, 2017-04-28 10:50:10]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 10:50:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 11:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 11:07:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-04-28 12:08:34]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 12:08:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:00:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:00:01]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-05-01 04:15:29]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 04:15:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-01 04:28:49]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 04:29:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-01 05:27:44]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-05-01 05:27:44]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-05-01 05:28:27]

tzik@chromium.org changed reviewers:
- dcheng@chromium.org

[commit-bot: I haz the power, 2017-05-01 05:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 05:36:30]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[tzik, 2017-05-01 07:25:04]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag affected rule, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-05-01 07:47:59]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 07:48:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-01 07:49:31]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag affected rule, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag affected rule, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-05-01 07:50:44]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-05-01 07:50:46]

PTAL

[commit-bot: I haz the power, 2017-05-01 08:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 08:54:20]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[dcheng, 2017-05-01 10:03:22]

lgtm

[tzik, 2017-05-08 05:31:01]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:31:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-08 06:13:24]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag affected rule, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag on affected rules, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tzik, 2017-05-08 06:14:24]

tzik@chromium.org changed reviewers:
+ sky@chromium.org

[tzik, 2017-05-08 06:17:05]

tzik@chromium.org changed reviewers:
+ danakj@chromium.org, jochen@chromium.org

[tzik, 2017-05-08 06:18:58]

tzik@chromium.org changed reviewers:
+ kinuko@chromium.org, rockot@chromium.org

[tzik, 2017-05-08 06:20:09]

tzik@chromium.org changed reviewers:
+ skyostil@chromium.org

[tzik, 2017-05-08 06:29:04]

tzik@chromium.org changed reviewers:
+ brettw@chromium.org, thakis@chromium.org, xhwang@chromium.org,
yzshen@chromium.org

[tzik, 2017-05-08 06:31:36]

Adding owners. PTAL to:
sky: //ash, //chrome, //ui
danakj: //cc
jochen: //components
kinuko: //content, //third_party/WebKit/public
rockot: //device, //ipc, //services
skyostil: //headless
xhwang: //media
yzshen: //mojo
thakis: //skia
brettw: //url

[commit-bot: I haz the power, 2017-05-08 07:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:31:24]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-05-08 09:47:37]

On 2017/05/08 06:31:36, tzik wrote:
> Adding owners. PTAL to:
> sky: //ash, //chrome, //ui
> danakj: //cc
> jochen: //components
> kinuko: //content, //third_party/WebKit/public

lgtm

> rockot: //device, //ipc, //services
> skyostil: //headless
> xhwang: //media
> yzshen: //mojo
> thakis: //skia
> brettw: //url

[Nico, 2017-05-08 13:40:54]

skia/ lgtm

(This adds 85 TODOs, maybe it's too early to flip the default?)

[Ken Rockot(use gerrit already), 2017-05-08 15:17:34]

LGTM - I think it's useful to have this work done up front in spite of all the
TODOs; now anyone can grep for 714018 and burn down the remaining uses of
Callback.

[sky, 2017-05-08 16:11:17]

LGTM

[xhwang, 2017-05-08 16:11:36]

media/ LGTM

[yzshen1, 2017-05-08 16:20:56]

On 2017/05/08 16:11:36, xhwang wrote:
> media/ LGTM

mojo/ LGTM

[Sami, 2017-05-08 17:15:05]

headless/ lgtm (+alexclarke@ FYI)

[jochen (gone - plz use gerrit), 2017-05-09 16:19:06]

lgtm

[danakj, 2017-05-09 22:42:50]

cc LGTM

[brettw, 2017-05-09 22:50:04]

lgtm

[tzik, 2017-05-10 08:00:51]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 08:02:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 10:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:11:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-05-10 10:48:15]

On 2017/05/08 13:40:54, Nico wrote:
> skia/ lgtm
> 
> (This adds 85 TODOs, maybe it's too early to flip the default?)

It's reduced to 66 now, and I have dozens of pendings to resolve them.
Most of them will be resolved soon hopefully. ;)

[tzik, 2017-05-10 10:48:41]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-10 10:48:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
rockot@chromium.org, jochen@chromium.org, sky@chromium.org, danakj@chromium.org,
kinuko@chromium.org, thakis@chromium.org, yzshen@chromium.org,
brettw@chromium.org, xhwang@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2843353004/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-10 10:49:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:22:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:22:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-05-10 13:23:58]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-10 13:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jochen@chromium.org, sky@chromium.org, danakj@chromium.org, dcheng@chromium.org,
kinuko@chromium.org, thakis@chromium.org, yzshen@chromium.org,
brettw@chromium.org, xhwang@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2843353004/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-10 13:24:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:40:22]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2017-05-11 03:20:25]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-11 03:22:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 07:14:34]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494472825960360,
"parent_rev": "250314432e59da58f1793f87bc4fa7512973f54a", "commit_rev":
"0639e21a33c73f3e316ce84a490b1d50ceaa024b"}

[commit-bot: I haz the power, 2017-05-11 07:14:49]

Description was changed from

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag on affected rules, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable use_once_callback on mojom GN rule by default

This CL enables use_once_callback flag on the Mojo code generation by
default, and disables the flag on affected rules, so that the new code starts
using OnceCallback by default, and we can track rules to migrate easily.

BUG=714018
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2843353004
Cr-Commit-Position: refs/heads/master@{#470858}
Committed:
https://chromium.googlesource.com/chromium/src/+/0639e21a33c73f3e316ce84a490b...
==========

[commit-bot: I haz the power, 2017-05-11 07:14:52]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/0639e21a33c73f3e316ce84a490b...