Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: mojo/common/BUILD.gn

Issue 2843353004: Enable use_once_callback on mojom GN rule by default (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/mojo/interfaces/BUILD.gn ('k') | mojo/public/interfaces/bindings/tests/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//mojo/public/tools/bindings/mojom.gni") 5 import("//mojo/public/tools/bindings/mojom.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 group("common") { 8 group("common") {
9 public_deps = [ 9 public_deps = [
10 ":common_base", 10 ":common_base",
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 } 46 }
47 47
48 mojom("test_common_custom_types") { 48 mojom("test_common_custom_types") {
49 sources = [ 49 sources = [
50 "test_common_custom_types.mojom", 50 "test_common_custom_types.mojom",
51 "traits_test_service.mojom", 51 "traits_test_service.mojom",
52 ] 52 ]
53 public_deps = [ 53 public_deps = [
54 ":common_custom_types", 54 ":common_custom_types",
55 ] 55 ]
56
57 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
58 use_once_callback = false
56 } 59 }
57 60
58 test("mojo_common_unittests") { 61 test("mojo_common_unittests") {
59 deps = [ 62 deps = [
60 ":common", 63 ":common",
61 ":common_custom_types", 64 ":common_custom_types",
62 ":struct_traits", 65 ":struct_traits",
63 ":test_common_custom_types", 66 ":test_common_custom_types",
64 "//base", 67 "//base",
65 "//base:message_loop_tests", 68 "//base:message_loop_tests",
(...skipping 19 matching lines...) Expand all
85 ] 88 ]
86 deps = [ 89 deps = [
87 ":common_custom_types_shared_cpp_sources", 90 ":common_custom_types_shared_cpp_sources",
88 "//base:base", 91 "//base:base",
89 "//mojo/public/cpp/system", 92 "//mojo/public/cpp/system",
90 ] 93 ]
91 public_deps = [ 94 public_deps = [
92 "//base:i18n", 95 "//base:i18n",
93 ] 96 ]
94 } 97 }
OLDNEW
« no previous file with comments | « media/mojo/interfaces/BUILD.gn ('k') | mojo/public/interfaces/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698