chrome/common/BUILD.gn - Issue 2843353004: Enable use_once_callback on mojom GN rule by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 2843353004: Enable use_once_callback on mojom GN rule by default (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index ddb2664b0af6d7626b04b9db6ac551bc870b7096..1e8cce5105983865255571d616e0081434b9b673 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -726,6 +726,9 @@ mojom("mojo_bindings") {

"//ui/gfx/geometry/mojo",

"//url/mojo:url_mojom_gurl",

]

+ # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.

+ use_once_callback = false

}

mojom("instant_mojom") {

« no previous file with comments | « chrome/browser/ui/webui/usb_internals/BUILD.gn ('k') | chrome/common/extensions/BUILD.gn » ('j') | no next file with comments »