Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/public/BUILD.gn

Issue 2843353004: Enable use_once_callback on mojom GN rule by default (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « skia/public/interfaces/BUILD.gn ('k') | ui/display/mojo/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//mojo/public/tools/bindings/mojom.gni") 6 import("//mojo/public/tools/bindings/mojom.gni")
7 import("//third_party/WebKit/public/public_features.gni") 7 import("//third_party/WebKit/public/public_features.gni")
8 import("//third_party/WebKit/Source/config.gni") 8 import("//third_party/WebKit/Source/config.gni")
9 import("//third_party/WebKit/Source/core/core.gni") 9 import("//third_party/WebKit/Source/core/core.gni")
10 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
(...skipping 729 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 # inside content. 740 # inside content.
741 export_class_attribute = "CONTENT_EXPORT" 741 export_class_attribute = "CONTENT_EXPORT"
742 export_define = "CONTENT_IMPLEMENTATION=1" 742 export_define = "CONTENT_IMPLEMENTATION=1"
743 export_header = "content/common/content_export.h" 743 export_header = "content/common/content_export.h"
744 744
745 # Similarly, the blink variant must be linked with the platform component 745 # Similarly, the blink variant must be linked with the platform component
746 # since it uses types from it in its typemaps. 746 # since it uses types from it in its typemaps.
747 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT" 747 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT"
748 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1" 748 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
749 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h" 749 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h"
750
751 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
752 use_once_callback = false
750 } 753 }
751 754
752 mojom("android_mojo_bindings") { 755 mojom("android_mojo_bindings") {
753 visibility = [ ":mojo_bindings" ] 756 visibility = [ ":mojo_bindings" ]
754 visibility_blink = [ ":mojo_bindings_blink" ] 757 visibility_blink = [ ":mojo_bindings_blink" ]
755 sources = [ 758 sources = [
756 "platform/modules/document_metadata/copyless_paste.mojom", 759 "platform/modules/document_metadata/copyless_paste.mojom",
757 "platform/modules/installation/installation.mojom", 760 "platform/modules/installation/installation.mojom",
758 "platform/modules/installedapp/installed_app_provider.mojom", 761 "platform/modules/installedapp/installed_app_provider.mojom",
759 "platform/modules/installedapp/related_application.mojom", 762 "platform/modules/installedapp/related_application.mojom",
760 "platform/modules/webshare/webshare.mojom", 763 "platform/modules/webshare/webshare.mojom",
761 ] 764 ]
762 public_deps = [ 765 public_deps = [
763 "//components/payments/mojom", 766 "//components/payments/mojom",
764 "//url/mojo:url_mojom_gurl", 767 "//url/mojo:url_mojom_gurl",
765 ] 768 ]
766 769
767 # See comment above. 770 # See comment above.
768 export_class_attribute = "CONTENT_EXPORT" 771 export_class_attribute = "CONTENT_EXPORT"
769 export_define = "CONTENT_IMPLEMENTATION=1" 772 export_define = "CONTENT_IMPLEMENTATION=1"
770 export_header = "content/common/content_export.h" 773 export_header = "content/common/content_export.h"
771 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT" 774 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT"
772 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1" 775 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
773 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h" 776 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h"
777
778 # TODO(crbug.com/714018): Convert the implementation to use OnceCallback.
779 use_once_callback = false
774 } 780 }
775 781
776 # The offscreen_canvas_mojo_bindings is separated from the rest of mojom files 782 # The offscreen_canvas_mojo_bindings is separated from the rest of mojom files
777 # because its deps contain too many files in Chromium that would pollute the 783 # because its deps contain too many files in Chromium that would pollute the
778 # include paths in generated mojom-blink files for other services. 784 # include paths in generated mojom-blink files for other services.
779 mojom("offscreen_canvas_mojo_bindings") { 785 mojom("offscreen_canvas_mojo_bindings") {
780 visibility = [ "//content/*" ] 786 visibility = [ "//content/*" ]
781 visibility_blink = [ "//third_party/WebKit/Source/platform" ] 787 visibility_blink = [ "//third_party/WebKit/Source/platform" ]
782 sources = [ 788 sources = [
783 "platform/modules/offscreencanvas/offscreen_canvas_surface.mojom", 789 "platform/modules/offscreencanvas/offscreen_canvas_surface.mojom",
784 ] 790 ]
785 deps = [ 791 deps = [
786 "//cc/ipc:interfaces", 792 "//cc/ipc:interfaces",
787 ] 793 ]
788 794
789 # See comment above 795 # See comment above
790 export_class_attribute = "CONTENT_EXPORT" 796 export_class_attribute = "CONTENT_EXPORT"
791 export_define = "CONTENT_IMPLEMENTATION=1" 797 export_define = "CONTENT_IMPLEMENTATION=1"
792 export_header = "content/common/content_export.h" 798 export_header = "content/common/content_export.h"
793 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT" 799 export_class_attribute_blink = "BLINK_PLATFORM_EXPORT"
794 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1" 800 export_define_blink = "BLINK_PLATFORM_IMPLEMENTATION=1"
795 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h" 801 export_header_blink = "third_party/WebKit/public/platform/WebCommon.h"
796 use_once_callback = true
797 } 802 }
798 803
799 group("generate_mojo_bindings") { 804 group("generate_mojo_bindings") {
800 deps = [ 805 deps = [
801 ":mojo_bindings_blink__generator", 806 ":mojo_bindings_blink__generator",
802 ":offscreen_canvas_mojo_bindings_blink__generator", 807 ":offscreen_canvas_mojo_bindings_blink__generator",
803 ] 808 ]
804 } 809 }
805 810
806 # Some mojom typemaps are shared between Chromium and Blink variants and 811 # Some mojom typemaps are shared between Chromium and Blink variants and
807 # therefore require some shared traits implementation. These definitions are 812 # therefore require some shared traits implementation. These definitions are
808 # relegated to a separate target to avoid duplication between the variants. 813 # relegated to a separate target to avoid duplication between the variants.
809 source_set("shared_typemap_traits") { 814 source_set("shared_typemap_traits") {
810 visibility = [ ":*" ] 815 visibility = [ ":*" ]
811 sources = [ 816 sources = [
812 "web/ConsoleMessageStructTraits.cpp", 817 "web/ConsoleMessageStructTraits.cpp",
813 "web/ConsoleMessageStructTraits.h", 818 "web/ConsoleMessageStructTraits.h",
814 ] 819 ]
815 deps = [ 820 deps = [
816 ":blink_headers", 821 ":blink_headers",
817 ":mojo_bindings_shared__generator", 822 ":mojo_bindings_shared__generator",
818 "//mojo/public/cpp/bindings:struct_traits", 823 "//mojo/public/cpp/bindings:struct_traits",
819 ] 824 ]
820 } 825 }
OLDNEW
« no previous file with comments | « skia/public/interfaces/BUILD.gn ('k') | ui/display/mojo/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698